You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/22 11:58:23 UTC
[GitHub] [shardingsphere] justbk2015 opened a new pull request #14999: add java version adapt for linux shell
justbk2015 opened a new pull request #14999:
URL: https://github.com/apache/shardingsphere/pull/14999
Fixes #14941.
Changes proposed in this pull request:
- cur java options support java8、java11 and java17
- the java version format must be: `1.x.x_x` or `1x.xx.xx`
- only support linux shell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu edited a comment on pull request #14999: add java version adapt for linux shell
Posted by GitBox <gi...@apache.org>.
terrymanu edited a comment on pull request #14999:
URL: https://github.com/apache/shardingsphere/pull/14999#issuecomment-1019287718
> I tried the command `java -version 2>&1 | sed '1!d' | sed -e 's/"//g' | awk '{print $3}'`, but the result is not expected:
>
> ```
> {22-01-22 22:43}bogon:~ wuweijie% java -version 2>&1 | sed '1!d' | sed -e 's/"//g' | awk '{print $3}'
> JAVA_TOOL_OPTIONS:
> ```
>
> The output of my `java -version`:
>
> ```
> {22-01-22 22:44}bogon:~ wuweijie% java -version
> Picked up JAVA_TOOL_OPTIONS: -Djava.net.preferIPv4Stack=true
> openjdk version "1.8.0_312"
> OpenJDK Runtime Environment (Zulu 8.58.0.13-CA-macos-aarch64) (build 1.8.0_312-b07)
> OpenJDK 64-Bit Server VM (Zulu 8.58.0.13-CA-macos-aarch64) (build 25.312-b07, mixed mode)
> ```
I try `java -version` in my laptop, the result is
```
openjdk version "1.8.0_292"
OpenJDK Runtime Environment Corretto-8.292.10.1 (build 1.8.0_292-b10)
OpenJDK 64-Bit Server VM Corretto-8.292.10.1 (build 25.292-b10, mixed mode)
```
So the result of `java -version 2>&1 | sed '1!d' | sed -e 's/"//g' | awk '{print $3}'` is: `1.8.0_292`
I think the problem is in the first line `Picked up JAVA_TOOL_OPTIONS: -Djava.net.preferIPv4Stack=true`
Is there any way to find the java version line and awk it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #14999: add java version adapt for linux shell
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #14999:
URL: https://github.com/apache/shardingsphere/pull/14999#issuecomment-1019287718
> I tried the command `java -version 2>&1 | sed '1!d' | sed -e 's/"//g' | awk '{print $3}'`, but the result is not expected:
>
> ```
> {22-01-22 22:43}bogon:~ wuweijie% java -version 2>&1 | sed '1!d' | sed -e 's/"//g' | awk '{print $3}'
> JAVA_TOOL_OPTIONS:
> ```
>
> The output of my `java -version`:
>
> ```
> {22-01-22 22:44}bogon:~ wuweijie% java -version
> Picked up JAVA_TOOL_OPTIONS: -Djava.net.preferIPv4Stack=true
> openjdk version "1.8.0_312"
> OpenJDK Runtime Environment (Zulu 8.58.0.13-CA-macos-aarch64) (build 1.8.0_312-b07)
> OpenJDK 64-Bit Server VM (Zulu 8.58.0.13-CA-macos-aarch64) (build 25.312-b07, mixed mode)
> ```
I try `java -version` in my laptop, the result is
```
openjdk version "1.8.0_292"
OpenJDK Runtime Environment Corretto-8.292.10.1 (build 1.8.0_292-b10)
OpenJDK 64-Bit Server VM Corretto-8.292.10.1 (build 25.292-b10, mixed mode)
```
So the result of `java -version 2>&1 | sed '1!d' | sed -e 's/"//g' | awk '{print $3}'` are: `1.8.0_292`
I think the problem is in the first line `Picked up JAVA_TOOL_OPTIONS: -Djava.net.preferIPv4Stack=true`
Is there any way to find the java version line and awk it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN merged pull request #14999: add java version adapt for linux shell
Posted by GitBox <gi...@apache.org>.
TeslaCN merged pull request #14999:
URL: https://github.com/apache/shardingsphere/pull/14999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN merged pull request #14999: add java version adapt for linux shell
Posted by GitBox <gi...@apache.org>.
TeslaCN merged pull request #14999:
URL: https://github.com/apache/shardingsphere/pull/14999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] justbk2015 commented on pull request #14999: add java version adapt for linux shell
Posted by GitBox <gi...@apache.org>.
justbk2015 commented on pull request #14999:
URL: https://github.com/apache/shardingsphere/pull/14999#issuecomment-1019289283
> > I tried the command `java -version 2>&1 | sed '1!d' | sed -e 's/"//g' | awk '{print $3}'`, but the result is not expected:
> > ```
> > {22-01-22 22:43}bogon:~ wuweijie% java -version 2>&1 | sed '1!d' | sed -e 's/"//g' | awk '{print $3}'
> > JAVA_TOOL_OPTIONS:
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > The output of my `java -version`:
> > ```
> > {22-01-22 22:44}bogon:~ wuweijie% java -version
> > Picked up JAVA_TOOL_OPTIONS: -Djava.net.preferIPv4Stack=true
> > openjdk version "1.8.0_312"
> > OpenJDK Runtime Environment (Zulu 8.58.0.13-CA-macos-aarch64) (build 1.8.0_312-b07)
> > OpenJDK 64-Bit Server VM (Zulu 8.58.0.13-CA-macos-aarch64) (build 25.312-b07, mixed mode)
> > ```
>
> I try `java -version` in my laptop, the result is
>
> ```
> openjdk version "1.8.0_292"
> OpenJDK Runtime Environment Corretto-8.292.10.1 (build 1.8.0_292-b10)
> OpenJDK 64-Bit Server VM Corretto-8.292.10.1 (build 25.292-b10, mixed mode)
> ```
>
> So the result of `java -version 2>&1 | sed '1!d' | sed -e 's/"//g' | awk '{print $3}'` is: `1.8.0_292`
>
> I think the problem is in the first line `Picked up JAVA_TOOL_OPTIONS: -Djava.net.preferIPv4Stack=true`
>
> Is there any way to find the java version line and awk it?
I noticed this problem , I will handle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #14999: add java version adapt for linux shell
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #14999:
URL: https://github.com/apache/shardingsphere/pull/14999#issuecomment-1019252026
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14999?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14999](https://codecov.io/gh/apache/shardingsphere/pull/14999?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f60f265) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ad2547199b0abab7c079abba934800be7f5a7b1e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad25471) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/14999?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14999 +/- ##
=========================================
Coverage 59.58% 59.58%
Complexity 1890 1890
=========================================
Files 3143 3143
Lines 46918 46918
Branches 7947 7947
=========================================
Hits 27957 27957
Misses 16754 16754
Partials 2207 2207
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14999?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14999?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ad25471...f60f265](https://codecov.io/gh/apache/shardingsphere/pull/14999?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org