You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/05 03:07:53 UTC

[GitHub] [kafka] kowshik opened a new pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

kowshik opened a new pull request #9562:
URL: https://github.com/apache/kafka/pull/9562


   Fixed the param doc in `FinalizedFeatureChangeListener.initOrThrow` method. The parameter `waitOnceForCacheUpdateMs` is expected to be > 0, but the doc was incorrect.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9562:
URL: https://github.com/apache/kafka/pull/9562#issuecomment-722124176


   @kowshik I have merged #9559. Could you rebase PR to trigger QA again?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kowshik commented on pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #9562:
URL: https://github.com/apache/kafka/pull/9562#issuecomment-722119275


   The build in CI is broken due to #9559 . I'll rebase on top of latest AK trunk, after that PR is merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9562:
URL: https://github.com/apache/kafka/pull/9562#issuecomment-722185108


   @kowshik Thanks for patch. Merge to trunk


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 merged pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #9562:
URL: https://github.com/apache/kafka/pull/9562


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kowshik edited a comment on pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

Posted by GitBox <gi...@apache.org>.
kowshik edited a comment on pull request #9562:
URL: https://github.com/apache/kafka/pull/9562#issuecomment-722119275


   The build in CI is broken due to absence of #9559. I'll rebase on top of latest AK trunk, after that PR is merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kowshik commented on pull request #9562: MINOR: Fix param doc in FinalizedFeatureChangeListener.initOrThrow

Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #9562:
URL: https://github.com/apache/kafka/pull/9562#issuecomment-722130040


   @chia7712 I've rebased now on top of #9559. Hopefully the build will go green. Thank you for the review!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org