You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2007/06/13 03:19:26 UTC
[jira] Commented: (HADOOP-1453) exists() not necessary before
DFS.open
[ https://issues.apache.org/jira/browse/HADOOP-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504078 ]
Raghu Angadi commented on HADOOP-1453:
--------------------------------------
I guess this is not enough. There is an exists() in ChecksumFileSystem.open() as well. Should that be removed as well? :
{code}
public FSDataInputStream open(Path f, int bufferSize) throws IOException {
if (!exists(f)) {
throw new FileNotFoundException(f.toString());
}
return new FSDataInputStream(new FSInputChecker(this, f, bufferSize),
bufferSize);
}
{code}
> exists() not necessary before DFS.open
> --------------------------------------
>
> Key: HADOOP-1453
> URL: https://issues.apache.org/jira/browse/HADOOP-1453
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Fix For: 0.14.0
>
> Attachments: HADOOP-1453-01.patch
>
>
> {code:title=DistributedFileSystem.java:131|borderStyle=solid}
> public FSDataInputStream open(Path f, int bufferSize) throws IOException {
> if (!exists(f)) {
> throw new FileNotFoundException(f.toString());
> }
> return new DFSClient.DFSDataInputStream(dfs.open(getPath(f)), bufferSize);
> }
> {code}
> {{exists(f)}} adds extra namenode interaction that is not really required. Open is a critical DFS call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.