You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "wangning (Code Review)" <ge...@cloudera.org> on 2021/02/23 07:50:12 UTC

[kudu-CR] [tserver] avoid copy when constructing Heartbeater

wangning has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17109


Change subject: [tserver] avoid copy when constructing Heartbeater
......................................................................

[tserver] avoid copy when constructing Heartbeater

Change-Id: Ic33583ea67339e06fd68a5d09cfd08304daa4115
---
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/heartbeater.h
2 files changed, 6 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/17109/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic33583ea67339e06fd68a5d09cfd08304daa4115
Gerrit-Change-Number: 17109
Gerrit-PatchSet: 1
Gerrit-Owner: wangning <19...@gmail.com>

[kudu-CR] [tserver] avoid copy when constructing Heartbeater

Posted by "wangning (Code Review)" <ge...@cloudera.org>.
wangning has posted comments on this change. ( http://gerrit.cloudera.org:8080/17109 )

Change subject: [tserver] avoid copy when constructing Heartbeater
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17109/1/src/kudu/tserver/heartbeater.h
File src/kudu/tserver/heartbeater.h:

http://gerrit.cloudera.org:8080/#/c/17109/1/src/kudu/tserver/heartbeater.h@a31
PS1, Line 31: 
            : 
            : 
It is shown as '^M' in vim.



-- 
To view, visit http://gerrit.cloudera.org:8080/17109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic33583ea67339e06fd68a5d09cfd08304daa4115
Gerrit-Change-Number: 17109
Gerrit-PatchSet: 1
Gerrit-Owner: wangning <19...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: wangning <19...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 07:52:34 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tserver] avoid copy when constructing Heartbeater

Posted by "wangning (Code Review)" <ge...@cloudera.org>.
wangning has abandoned this change. ( http://gerrit.cloudera.org:8080/17109 )

Change subject: [tserver] avoid copy when constructing Heartbeater
......................................................................


Abandoned

misunderstood
-- 
To view, visit http://gerrit.cloudera.org:8080/17109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic33583ea67339e06fd68a5d09cfd08304daa4115
Gerrit-Change-Number: 17109
Gerrit-PatchSet: 1
Gerrit-Owner: wangning <19...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: wangning <19...@gmail.com>