You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by sa...@apache.org on 2021/05/06 06:29:31 UTC

svn commit: r1889551 - in /poi/trunk/poi-ooxml/src: main/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java test/java/org/apache/poi/xwpf/usermodel/TestXWPFParagraph.java

Author: sayi
Date: Thu May  6 06:29:31 2021
New Revision: 1889551

URL: http://svn.apache.org/viewvc?rev=1889551&view=rev
Log:
#65282 - addRun method only adds to run collection, missing iRun collection

Modified:
    poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java
    poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFParagraph.java

Modified: poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java?rev=1889551&r1=1889550&r2=1889551&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java (original)
+++ poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java Thu May  6 06:29:31 2021
@@ -1852,6 +1852,7 @@ public class XWPFParagraph implements IB
     public void addRun(XWPFRun r) {
         if (!runs.contains(r)) {
             runs.add(r);
+            iruns.add(r);
         }
     }
 

Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFParagraph.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFParagraph.java?rev=1889551&r1=1889550&r2=1889551&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFParagraph.java (original)
+++ poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFParagraph.java Thu May  6 06:29:31 2021
@@ -330,15 +330,23 @@ public final class TestXWPFParagraph {
 
             XWPFParagraph p = doc.getParagraphs().get(0);
             assertEquals(2, p.getRuns().size());
+            assertEquals(2, p.getIRuns().size());
 
             XWPFRun r = p.createRun();
             assertEquals(3, p.getRuns().size());
             assertEquals(2, p.getRuns().indexOf(r));
 
+            assertEquals(3, p.getIRuns().size());
+            assertEquals(2, p.getIRuns().indexOf(r));
+
             XWPFRun r2 = p.insertNewRun(1);
             assertEquals(4, p.getRuns().size());
             assertEquals(1, p.getRuns().indexOf(r2));
             assertEquals(3, p.getRuns().indexOf(r));
+
+            assertEquals(4, p.getIRuns().size());
+            assertEquals(1, p.getIRuns().indexOf(r2));
+            assertEquals(3, p.getIRuns().indexOf(r));
         }
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org