You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/22 17:27:58 UTC

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7245: ARROW-8885: [R] Don't include everything everywhere

fsaintjacques commented on a change in pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#discussion_r429369559



##########
File path: r/src/array_from_vector.cpp
##########
@@ -20,6 +20,11 @@
 #include "./arrow_types.h"
 
 #if defined(ARROW_R_WITH_ARROW)
+#include <arrow/array.h>
+#include <arrow/builder.h>
+#include <arrow/table.h>
+// This says "Private header, not to be exported"

Review comment:
       Yep, this is fine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org