You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Justin Mclean <ju...@classsoftware.com> on 2012/12/19 08:05:04 UTC
Re: svn commit: r1423770 - /incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
Is this required for the 4.9 release? I'm not 100% sure it is.
> Author: fthomas
> Date: Wed Dec 19 06:43:08 2012
> New Revision: 1423770
>
> URL: http://svn.apache.org/viewvc?rev=1423770&view=rev
> Log:
> FLEX-33316 checkintests fails on no english OS
>
> Modified:
> incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
>
> Modified: incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
> URL: http://svn.apache.org/viewvc/incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java?rev=1423770&r1=1423769&r2=1423770&view=diff
> ==============================================================================
> --- incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java (original)
> +++ incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java Wed Dec 19 06:43:08 2012
> @@ -151,6 +151,9 @@ public class MustellaResultsParser {
> else if (s.startsWith("[IOErrorEvent type=\"ioError\"") && s.contains("localhost:9999/ScriptComplete"))
> {
> }
> + else if (s.startsWith("Avertissement"))
> + {
> + }
> else if (s.trim().equals(""))
> {
> }
>
>
Re: svn commit: r1423770 -
/incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
Posted by Alex Harui <ah...@adobe.com>.
I don't think this is a locales issue. I think it is an OS language issue.
On 12/18/12 11:22 PM, "Frédéric THOMAS" <we...@hotmail.com> wrote:
> Hi,
>
>> Currently it rather unlikely the Mustella tests will run on different
>> locales because of different month name in data pickers
>
> Can you remember which test it is ?
>
> - Fred
>
> -----Message d'origine-----
> From: Justin Mclean
> Sent: Wednesday, December 19, 2012 8:15 AM
> To: flex-dev@incubator.apache.org
> Subject: Re: svn commit: r1423770 -
> /incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
>
> Hi,
>
>> This one and the the patches relative to the internationalized Mustella
>> Test Suite are required only if you want folks be able to run the test
>> suite on no english OS.
>
> Currently it rather unlikely the Mustella tests will run on different
> locales because of different month name in data pickers (and a few other
> things). I've also run into issues with the checkin tests and the Alter
> popup box not disappearing.
>
> Do we really want to wait to get all tests to pass in all locales before
> making a release?
>
> Thanks,
> Justin
>
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: svn commit: r1423770 - /incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
Posted by Frédéric THOMAS <we...@hotmail.com>.
Hi,
> Currently it rather unlikely the Mustella tests will run on different
> locales because of different month name in data pickers
Can you remember which test it is ?
- Fred
-----Message d'origine-----
From: Justin Mclean
Sent: Wednesday, December 19, 2012 8:15 AM
To: flex-dev@incubator.apache.org
Subject: Re: svn commit: r1423770 -
/incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
Hi,
> This one and the the patches relative to the internationalized Mustella
> Test Suite are required only if you want folks be able to run the test
> suite on no english OS.
Currently it rather unlikely the Mustella tests will run on different
locales because of different month name in data pickers (and a few other
things). I've also run into issues with the checkin tests and the Alter
popup box not disappearing.
Do we really want to wait to get all tests to pass in all locales before
making a release?
Thanks,
Justin
Re: svn commit: r1423770 - /incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> This one and the the patches relative to the internationalized Mustella Test Suite are required only if you want folks be able to run the test suite on no english OS.
Currently it rather unlikely the Mustella tests will run on different locales because of different month name in data pickers (and a few other things). I've also run into issues with the checkin tests and the Alter popup box not disappearing.
Do we really want to wait to get all tests to pass in all locales before making a release?
Thanks,
Justin
Re: svn commit: r1423770 - /incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
Posted by Frédéric THOMAS <we...@hotmail.com>.
Hi,
This one and the the patches relative to the internationalized Mustella Test
Suite are required only if you want folks be able to run the test suite on
no english OS.
- Fred
-----Message d'origine-----
From: Justin Mclean
Sent: Wednesday, December 19, 2012 8:05 AM
To: flex-dev@incubator.apache.org
Subject: Re: svn commit: r1423770 -
/incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
Is this required for the 4.9 release? I'm not 100% sure it is.
> Author: fthomas
> Date: Wed Dec 19 06:43:08 2012
> New Revision: 1423770
>
> URL: http://svn.apache.org/viewvc?rev=1423770&view=rev
> Log:
> FLEX-33316 checkintests fails on no english OS
>
> Modified:
>
> incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
>
> Modified:
> incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
> URL:
> http://svn.apache.org/viewvc/incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java?rev=1423770&r1=1423769&r2=1423770&view=diff
> ==============================================================================
> ---
> incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
> (original)
> +++
> incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
> Wed Dec 19 06:43:08 2012
> @@ -151,6 +151,9 @@ public class MustellaResultsParser {
> else if (s.startsWith("[IOErrorEvent type=\"ioError\"") &&
> s.contains("localhost:9999/ScriptComplete"))
> {
> }
> + else if (s.startsWith("Avertissement"))
> + {
> + }
> else if (s.trim().equals(""))
> {
> }
>
>
Re: svn commit: r1423770 - /incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Yep, looks like a false alarm, sorry about that.
Justin
Re: svn commit: r1423770 - /incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
Posted by Om <bi...@gmail.com>.
On Tue, Dec 18, 2012 at 11:37 PM, Justin Mclean <ju...@classsoftware.com>wrote:
> HI,
>
> > It is for checkintests to pass in French OS. I think it is ok to take.
>
> Sadly not - I think it just broke the check in test for english.
>
> https://builds.apache.org/job/Flex_SDK_checkin_tests/28/console
>
> Justin
>
BTW, this build did not copy the flashlog.txt into the workspace. I have
fixed the Jenkins job to copy the flashlog.txt in case of a BUILD FAILED
result as well now.
If you want to see what happened, we can trigger a new build right away.
Re: svn commit: r1423770 - /incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
Posted by Frédéric THOMAS <we...@hotmail.com>.
Hi,
> Sadly not - I think it just broke the check in test for english.
Not sure that's the reason, it's just another if statement.
- Fred
-----Message d'origine-----
From: Justin Mclean
Sent: Wednesday, December 19, 2012 8:37 AM
To: flex-dev@incubator.apache.org
Subject: Re: svn commit: r1423770 -
/incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
HI,
> It is for checkintests to pass in French OS. I think it is ok to take.
Sadly not - I think it just broke the check in test for english.
https://builds.apache.org/job/Flex_SDK_checkin_tests/28/console
Justin
Re: svn commit: r1423770 -
/incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
Posted by Alex Harui <ah...@adobe.com>.
On 12/18/12 11:37 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
> HI,
>
>> It is for checkintests to pass in French OS. I think it is ok to take.
>
> Sadly not - I think it just broke the check in test for english.
>
> https://builds.apache.org/job/Flex_SDK_checkin_tests/28/console
>
Well, I suppose it is possible that his change broke the build, but I would
need to be convinced. The file he changed hasn't even run at the point of
failure. It is more likely a timing issue in the test.
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: svn commit: r1423770 - /incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
> It is for checkintests to pass in French OS. I think it is ok to take.
Sadly not - I think it just broke the check in test for english.
https://builds.apache.org/job/Flex_SDK_checkin_tests/28/console
Justin
Re: svn commit: r1423770 -
/incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
Posted by Alex Harui <ah...@adobe.com>.
It is for checkintests to pass in French OS. I think it is ok to take.
BTW, I have some hard failures on Win with FP11.5. I haven't had time to
look into it yet, but we may need to edit the readme again about what we
know about different players.
On 12/18/12 11:05 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
> Is this required for the 4.9 release? I'm not 100% sure it is.
>
>> Author: fthomas
>> Date: Wed Dec 19 06:43:08 2012
>> New Revision: 1423770
>>
>> URL: http://svn.apache.org/viewvc?rev=1423770&view=rev
>> Log:
>> FLEX-33316 checkintests fails on no english OS
>>
>> Modified:
>> incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
>>
>> Modified:
>> incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/flex/sdk/branches/release4.9/mustella/
>> MustellaResultsParser.java?rev=1423770&r1=1423769&r2=1423770&view=diff
>>
=============================================================================>>
=
>> ---
>> incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
>> (original)
>> +++
>> incubator/flex/sdk/branches/release4.9/mustella/MustellaResultsParser.java
>> Wed Dec 19 06:43:08 2012
>> @@ -151,6 +151,9 @@ public class MustellaResultsParser {
>> else if (s.startsWith("[IOErrorEvent type=\"ioError\"") &&
>> s.contains("localhost:9999/ScriptComplete"))
>> {
>> }
>> + else if (s.startsWith("Avertissement"))
>> + {
>> + }
>> else if (s.trim().equals(""))
>> {
>> }
>>
>>
>
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui