[GitHub] [flink] godfreyhe commented on issue #10694: [FLINK-15381] [table-planner-blink] correct collation derive logic on RelSubset in RelMdCollation

[GitBox <gi...@apache.org>]

godfreyhe commented on issue #10694: [FLINK-15381] [table-planner-blink] correct collation derive logic on RelSubset in RelMdCollation
URL: https://github.com/apache/flink/pull/10694#issuecomment-570110015
 
 
   > @godfreyhe ,the fix makes sense.
   > However, it's better to fix the bug in Calcite.
   > Or Mark "The class should be removed after CALCITE-{JIARANUMBER} is fixed." in the header comment of the class.
   > What do you think?
   
   thanks for the suggestion @beyond1920 . Flink had rewritten most metadata handlers defined in Calcite. I think we should keep this class in order to support more `RelNode`s (many `RelNode`s can derive collation, like Rank). So I would like to add some comments in `public ImmutableList<RelCollation> collations(RelSubset subset, RelMetadataQuery mq)`  method instead of in the header of the class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services