[GitHub] [hadoop] smengcl commented on a diff in pull request #4474: HADOOP-18306: Warnings should not be shown on cli console when linux user not present on client

[GitBox <gi...@apache.org>]

smengcl commented on code in PR #4474:
URL: https://github.com/apache/hadoop/pull/4474#discussion_r901931491


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java:
##########
@@ -215,7 +215,13 @@ private Set<String> getUnixGroups(String user) throws IOException {
           groups = resolvePartialGroupNames(user, e.getMessage(),
               executor.getOutput());
         } catch (PartialGroupNameException pge) {
-          LOG.warn("unable to return groups for user {}", user, pge);
+          if(LOG.isDebugEnabled()) {

Review Comment:
   IMO this is fine.
   
   @swamirishi Just be sure to double check the debug log can actually be enabled for example by setting `org.apache.hadoop.security.ShellBasedUnixGroupsMapping=DEBUG` in `log4j.properties` or JVM `-D` param.
   
   nit: checkstyle



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org