You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/02 06:04:40 UTC
[GitHub] [tvm] quic-sanirudh opened a new pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
quic-sanirudh opened a new pull request #9422:
URL: https://github.com/apache/tvm/pull/9422
This PR tries to change the TVMScript printers to use `T` alias for the `tir` module as discussed in the [discussion here](https://github.com/apache/tvm/pull/9315#issuecomment-950078661)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-957612091
I think we can skip printing the import prefix, and let parser detect T (and tir) as namespace by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
quic-sanirudh commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-961784275
> > I think we can skip printing the import prefix, and let parser detect T (and tir) as namespace by default
>
> Yes, that makes sense, thanks @tqchen. I'll make those changes and update the PR.
I see that the parser [already supports](https://github.com/apache/tvm/blob/e24c0754a537ff05154624a1e8e23608651c0a4e/python/tvm/script/parser.py#L1091) both `tir` and `T` as the namespace, when the `prim_func` source is passed as string.
If the function is directly passed to the `tvm.script.parser.from_source()`, then the namespace is [automatically identified](https://github.com/apache/tvm/blob/e24c0754a537ff05154624a1e8e23608651c0a4e/python/tvm/script/parser.py#L1096).
So, I think either way, the parser can already handle using `T` as the namespace. For python, however, finding the `T` symbol in its symbol table requires that we import `T`, so instead of printing the import prefix and handling the cases, shall we just print a comment as a header mentioning import prefix to be used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-961900884
@quic-sanirudh That sounds like a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
quic-sanirudh commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-957287696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh edited a comment on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
quic-sanirudh edited a comment on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-957287696
Some tests are failing because of the header `from tvm.script import tir as T` when being passed into the `tvm.script.from_source()` function.
I see 2 potential ways to fix this and wanted to get suggestions on which might be better:
1. First is to add a new boolean argument to the `.script()` function called `print_header`, that is set to `True` by default, but passed as `False` when they're passed to `from_source` function.
- The disadvantage here is that this would mean anyone who uses this (`from_source()`) or any other similar function needs to know that the `print_header` should be set to `False`.
- An alternative is to set `print_header` to `False` by default, and use `print_header=True` in our docs as a convention.
2. Second is to modify the `from_source` such that it considers only the lines starting from a decorator such as `@T.prim_func` or `@tvm.script.ir_module`. (i.e. the first line of the source would be a line starting with `@` and everything above would be discarded.).
- I don't see any major disadvantage here except that we need to do some string manipulation of the generated script directly
3. There could be a third simpler option, which is just to assume that the header is alwyas just a single import statement, so we can just check for and remove that.
@Hzfengsy @junrushao1994 Both first and third options seem straight forward, but let me know what you think.
Thanks,
Anirudh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
quic-sanirudh commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-961784275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
quic-sanirudh commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-957704120
> I think we can skip printing the import prefix, and let parser detect T (and tir) as namespace by default
Yes, that makes sense, thanks @tqchen. I'll make those changes and update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-962049515
Hey shall we move fast and get this PR before the Monday cut for v0.8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-957612091
I think we can skip printing the import prefix, and let parser detect T (and tir) as namespace by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-962049515
Hey shall we move fast and get this PR before the Monday cut for v0.8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-961900884
@quic-sanirudh That sounds like a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-957612091
I think we can skip printing the import prefix, and let parser detect T (and tir) as namespace by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#discussion_r743824214
##########
File path: tests/python/unittest/test_tvmscript_error_report.py
##########
@@ -548,9 +548,10 @@ def test_reorder_fail_block():
sch.reorder(l, i)
expected_sub_error_message = (
" # tir.Block#0\n"
- ' with tir.block("B"):\n'
- " ^^^^^^^^^^^^^^^^^^^^\n"
+ ' with T.block("B"):\n'
+ " ^^^^^^^^^^^^^^^^^^\n"
)
+ print("expected: ", expected_sub_error_message, "actual: ", str(execinfo.value))
Review comment:
Hey shall we remove the print here?
##########
File path: tests/python/unittest/test_tvmscript_error_report.py
##########
@@ -548,9 +548,10 @@ def test_reorder_fail_block():
sch.reorder(l, i)
expected_sub_error_message = (
" # tir.Block#0\n"
- ' with tir.block("B"):\n'
- " ^^^^^^^^^^^^^^^^^^^^\n"
+ ' with T.block("B"):\n'
+ " ^^^^^^^^^^^^^^^^^^\n"
)
+ print("expected: ", expected_sub_error_message, "actual: ", str(execinfo.value))
Review comment:
Hey shall we remove the print here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-962049515
Hey shall we move fast and get this PR before the Monday cut for v0.8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #9422:
URL: https://github.com/apache/tvm/pull/9422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh edited a comment on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
quic-sanirudh edited a comment on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-957287696
Some tests are failing because of the header `from tvm.script import tir as T` when being passed into the `tvm.script.from_source()` function.
I see 2 potential ways to fix this and wanted to get suggestions on which might be better:
1. First is to add a new boolean argument to the `.script()` function called `print_header`, that is set to `True` by default, but passed as `False` when they're passed to `from_source` function.
- The disadvantage here is that this would mean anyone who uses this (`from_source()`) or any other similar function needs to know that the `print_header` should be set to `False`.
- An alternative is to set `print_header` to `False` by default, and use `print_header=True` in our docs as a convention.
2. Second is to modify the `from_source` such that it considers only the lines starting from a decorator such as `@T.prim_func` or `@tvm.script.ir_module`. (i.e. the first line of the source would be a line starting with `@` and everything above would be discarded.).
- I don't see any major disadvantage here except that we need to do some string manipulation of the generated script directly
3. There could be a third simpler option, which is just to assume that the header is alwyas just a single import statement, so we can just check for and remove that.
@Hzfengsy @junrushao1994 Both first and third options seem straight forward, but let me know what you think.
Thanks,
Anirudh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
quic-sanirudh commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-957287696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
quic-sanirudh commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-962051378
> Hey shall we move fast and get this PR before the Monday cut for v0.8?
Just pushed the updated patch. Hope the tests pass this time, thanks for the fast reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#discussion_r743824214
##########
File path: tests/python/unittest/test_tvmscript_error_report.py
##########
@@ -548,9 +548,10 @@ def test_reorder_fail_block():
sch.reorder(l, i)
expected_sub_error_message = (
" # tir.Block#0\n"
- ' with tir.block("B"):\n'
- " ^^^^^^^^^^^^^^^^^^^^\n"
+ ' with T.block("B"):\n'
+ " ^^^^^^^^^^^^^^^^^^\n"
)
+ print("expected: ", expected_sub_error_message, "actual: ", str(execinfo.value))
Review comment:
Hey shall we remove the print here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on a change in pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on a change in pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#discussion_r740746576
##########
File path: src/printer/tvmscript_printer.cc
##########
@@ -310,6 +310,13 @@ class TVMScriptPrinter : public StmtFunctor<Doc(const Stmt&)>,
}
return doc;
}
+
+ public:
+ static Doc PrintHeader(const std::string& tir_prefix) {
+ Doc header;
+ header << "from tvm.script import tir as " << tir_prefix << Doc::NewLine();
Review comment:
```suggestion
if (tir_prefix != "tir") {
header << "from tvm.script import tir as " << tir_prefix << Doc::NewLine();
} else {
header << "from tvm.script import tir" << Doc::NewLine();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on a change in pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on a change in pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#discussion_r740746576
##########
File path: src/printer/tvmscript_printer.cc
##########
@@ -310,6 +310,13 @@ class TVMScriptPrinter : public StmtFunctor<Doc(const Stmt&)>,
}
return doc;
}
+
+ public:
+ static Doc PrintHeader(const std::string& tir_prefix) {
+ Doc header;
+ header << "from tvm.script import tir as " << tir_prefix << Doc::NewLine();
Review comment:
```suggestion
if (tir_prefix != "tir") {
header << "from tvm.script import tir as " << tir_prefix << Doc::NewLine();
} else {
header << "from tvm.script import tir" << Doc::NewLine();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh edited a comment on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
quic-sanirudh edited a comment on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-957287696
Some tests are failing because of the header `from tvm.script import tir as T` when being passed into the `tvm.script.from_source()` function.
I see 2 potential ways to fix this and wanted to get suggestions on which might be better:
1. First is to add a new boolean argument to the `.script()` function called `print_header`, that is set to `True` by default, but passed as `False` when they're passed to `from_source` function.
- The disadvantage here is that this would mean anyone who uses this (`from_source()`) or any other similar function needs to know that the `print_header` should be set to `False`.
- An alternative is to set `print_header` to `False` by default, and use `print_header=True` in our docs as a convention.
2. Second is to modify the `from_source` such that it considers only the lines starting from a decorator such as `@T.prim_func` or `@tvm.script.ir_module`. (i.e. the first line of the source would be a line starting with `@` and everything above would be discarded.).
- I don't see any major disadvantage here except that we need to do some string manipulation of the generated script directly
3. There could be a third simpler option, which is just to assume that the header is alwyas just a single import statement, so we can just check for and remove that.
@Hzfengsy @junrushao1994 Both first and third options seem straight forward, but let me know what you think.
Thanks,
Anirudh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
quic-sanirudh commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-957287696
Some tests are failing because of the header `from tvm.script import tir as T` when being passed into the `tvm.script.from_source()` function.
I see 2 potential ways to fix this and wanted to get suggestions on which might be better:
1. First is to add a new boolean argument to the `.script()` function called `print_header`, that is set to `True` by default, but passed as `False` when they're passed to `from_source` function. This would mean anyone who uses this (`from_source()`) function needs to know that the `print_header` should be set to `False`.
2. Second is to modify the `from_source` such that it considers only the lines starting from a decorator such as `@T.prim_func` or `@tvm.script.ir_module`. (i.e. the first line of the source would be a line starting with `@` and everything above would be discarded.
Personally, I think the second option seems preferable to me, but let me know what you think. @Hzfengsy @junrushao1994
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on a change in pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on a change in pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#discussion_r740746576
##########
File path: src/printer/tvmscript_printer.cc
##########
@@ -310,6 +310,13 @@ class TVMScriptPrinter : public StmtFunctor<Doc(const Stmt&)>,
}
return doc;
}
+
+ public:
+ static Doc PrintHeader(const std::string& tir_prefix) {
+ Doc header;
+ header << "from tvm.script import tir as " << tir_prefix << Doc::NewLine();
Review comment:
```suggestion
if (tir_prefix != "tir") {
header << "from tvm.script import tir as " << tir_prefix << Doc::NewLine();
} else {
header << "from tvm.script import tir" << Doc::NewLine();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
quic-sanirudh commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-961784275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#issuecomment-961900884
@quic-sanirudh That sounds like a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh commented on a change in pull request #9422: [TensorIR] Print TVMScript with prefix T instead of tir
Posted by GitBox <gi...@apache.org>.
quic-sanirudh commented on a change in pull request #9422:
URL: https://github.com/apache/tvm/pull/9422#discussion_r744058556
##########
File path: tests/python/unittest/test_tvmscript_error_report.py
##########
@@ -548,9 +548,10 @@ def test_reorder_fail_block():
sch.reorder(l, i)
expected_sub_error_message = (
" # tir.Block#0\n"
- ' with tir.block("B"):\n'
- " ^^^^^^^^^^^^^^^^^^^^\n"
+ ' with T.block("B"):\n'
+ " ^^^^^^^^^^^^^^^^^^\n"
)
+ print("expected: ", expected_sub_error_message, "actual: ", str(execinfo.value))
Review comment:
Done, sorry about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org