[GitHub] [superset] betodealmeida commented on a change in pull request #16814: fix: Explore button not rendering after running query

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #16814:
URL: https://github.com/apache/superset/pull/16814#discussion_r715082851



##########
File path: superset-frontend/src/SqlLab/components/ExploreResultsButton.jsx
##########
@@ -152,14 +152,11 @@ class ExploreResultsButton extends React.PureComponent {
   }
 
   render() {
-    const allowsSubquery =
-      this.props.database && this.props.database.allows_subquery;

Review comment:
       Hugh, why are we removing this? In databases that don't support subqueries we can't show the button because Explore will fail.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org