You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Michael Brohl <mi...@ecomify.de> on 2018/02/19 21:27:37 UTC
Re: svn commit: r1824807 -
/ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbi
z/webapp/control/LoginWorker.java
Jacques,
I won't correct you commit messages. This is a repeating issue.
From now on, we will just not include those commits in the blog dev
details.
Am 19.02.18 um 22:07 schrieb Jacques Le Roux:
> Please Michael,
>
> I had a very rude day, we are a team, if you fill it needs a log
> change please do
>
> Thanks
>
> Jacques
>
>
> Le 19/02/2018 à 20:59, Michael Brohl a écrit :
>> So this is a bugfix and should read "Fixed: ..."
>>
>> *sigh*
>>
>>
>> Am 19.02.18 um 20:43 schrieb jleroux@apache.org:
>>> Author: jleroux
>>> Date: Mon Feb 19 19:43:15 2018
>>> New Revision: 1824807
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1824807&view=rev
>>> Log:
>>> No functional change, this missed an import in last backported commit
>>>
>>> Modified:
>>> ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>>>
>>>
>>> Modified:
>>> ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java?rev=1824807&r1=1824806&r2=1824807&view=diff
>>> ==============================================================================
>>>
>>> ---
>>> ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>>> (original)
>>> +++
>>> ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>>> Mon Feb 19 19:43:15 2018
>>> @@ -24,6 +24,7 @@ import java.math.BigInteger;
>>> import java.security.cert.X509Certificate;
>>> import java.sql.Timestamp;
>>> import java.util.ArrayList;
>>> +import java.util.Arrays;
>>> import java.util.Collection;
>>> import java.util.LinkedList;
>>> import java.util.List;
>>>
>>>
>>
>>
>
Re: svn commit: r1824807 -
/ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbi
z/webapp/control/LoginWorker.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
I reverted it with r1824889
It was put in with r1811430 and it was my bad to no see that when it was automatically merged
I must agree I'm too much committed. And last day was a misery for me.
Jacques
Le 20/02/2018 à 05:09, Scott Gray a écrit :
> Jacques, as a first step, please consider not using "no functional change"
> any longer. It used to be that it was simply used for basic formatting
> fixes, but now that I look closer, I notice you've had a trend going for a
> while now that you're using it for anything you consider to be minor.
> Examples include library upgrades, documentation changes, bug fixes, code
> comments, etc. Aside from the current commit which was a fix, I think you
> could simply replace "No functional change" with "Improves:" and you'd
> suddenly be mostly inline with the community guidelines on commit messages.
>
> Additionally, I see that you've made 89 edits to your commit messages this
> year, out of 191 commits. Surely you can agree that is quite excessive and
> perhaps you need to slow down and think a little more before pushing your
> commits?
>
> Regards
> Scott
>
> On 20 February 2018 at 10:27, Michael Brohl <mi...@ecomify.de>
> wrote:
>
>> Jacques,
>>
>> I won't correct you commit messages. This is a repeating issue.
>>
>> From now on, we will just not include those commits in the blog dev
>> details.
>>
>> Am 19.02.18 um 22:07 schrieb Jacques Le Roux:
>>
>> Please Michael,
>>> I had a very rude day, we are a team, if you fill it needs a log change
>>> please do
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>> Le 19/02/2018 à 20:59, Michael Brohl a écrit :
>>>
>>>> So this is a bugfix and should read "Fixed: ..."
>>>>
>>>> *sigh*
>>>>
>>>>
>>>> Am 19.02.18 um 20:43 schrieb jleroux@apache.org:
>>>>
>>>>> Author: jleroux
>>>>> Date: Mon Feb 19 19:43:15 2018
>>>>> New Revision: 1824807
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1824807&view=rev
>>>>> Log:
>>>>> No functional change, this missed an import in last backported commit
>>>>>
>>>>> Modified:
>>>>> ofbiz/branches/release16.11/framework/webapp/src/main/java/
>>>>> org/apache/ofbiz/webapp/control/LoginWorker.java
>>>>>
>>>>> Modified: ofbiz/branches/release16.11/framework/webapp/src/main/java/
>>>>> org/apache/ofbiz/webapp/control/LoginWorker.java
>>>>> URL: http://svn.apache.org/viewvc/ofbiz/branches/release16.11/fra
>>>>> mework/webapp/src/main/java/org/apache/ofbiz/webapp/contro
>>>>> l/LoginWorker.java?rev=1824807&r1=1824806&r2=1824807&view=diff
>>>>> ==============================================================================
>>>>>
>>>>> --- ofbiz/branches/release16.11/framework/webapp/src/main/java/
>>>>> org/apache/ofbiz/webapp/control/LoginWorker.java (original)
>>>>> +++ ofbiz/branches/release16.11/framework/webapp/src/main/java/
>>>>> org/apache/ofbiz/webapp/control/LoginWorker.java Mon Feb 19 19:43:15
>>>>> 2018
>>>>> @@ -24,6 +24,7 @@ import java.math.BigInteger;
>>>>> import java.security.cert.X509Certificate;
>>>>> import java.sql.Timestamp;
>>>>> import java.util.ArrayList;
>>>>> +import java.util.Arrays;
>>>>> import java.util.Collection;
>>>>> import java.util.LinkedList;
>>>>> import java.util.List;
>>>>>
>>>>>
>>>>>
>>>>
>>
Re: svn commit: r1824807 - /ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbi
z/webapp/control/LoginWorker.java
Posted by Scott Gray <sc...@hotwaxsystems.com>.
Jacques, as a first step, please consider not using "no functional change"
any longer. It used to be that it was simply used for basic formatting
fixes, but now that I look closer, I notice you've had a trend going for a
while now that you're using it for anything you consider to be minor.
Examples include library upgrades, documentation changes, bug fixes, code
comments, etc. Aside from the current commit which was a fix, I think you
could simply replace "No functional change" with "Improves:" and you'd
suddenly be mostly inline with the community guidelines on commit messages.
Additionally, I see that you've made 89 edits to your commit messages this
year, out of 191 commits. Surely you can agree that is quite excessive and
perhaps you need to slow down and think a little more before pushing your
commits?
Regards
Scott
On 20 February 2018 at 10:27, Michael Brohl <mi...@ecomify.de>
wrote:
> Jacques,
>
> I won't correct you commit messages. This is a repeating issue.
>
> From now on, we will just not include those commits in the blog dev
> details.
>
> Am 19.02.18 um 22:07 schrieb Jacques Le Roux:
>
> Please Michael,
>>
>> I had a very rude day, we are a team, if you fill it needs a log change
>> please do
>>
>> Thanks
>>
>> Jacques
>>
>>
>> Le 19/02/2018 à 20:59, Michael Brohl a écrit :
>>
>>> So this is a bugfix and should read "Fixed: ..."
>>>
>>> *sigh*
>>>
>>>
>>> Am 19.02.18 um 20:43 schrieb jleroux@apache.org:
>>>
>>>> Author: jleroux
>>>> Date: Mon Feb 19 19:43:15 2018
>>>> New Revision: 1824807
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1824807&view=rev
>>>> Log:
>>>> No functional change, this missed an import in last backported commit
>>>>
>>>> Modified:
>>>> ofbiz/branches/release16.11/framework/webapp/src/main/java/
>>>> org/apache/ofbiz/webapp/control/LoginWorker.java
>>>>
>>>> Modified: ofbiz/branches/release16.11/framework/webapp/src/main/java/
>>>> org/apache/ofbiz/webapp/control/LoginWorker.java
>>>> URL: http://svn.apache.org/viewvc/ofbiz/branches/release16.11/fra
>>>> mework/webapp/src/main/java/org/apache/ofbiz/webapp/contro
>>>> l/LoginWorker.java?rev=1824807&r1=1824806&r2=1824807&view=diff
>>>> ==============================================================================
>>>>
>>>> --- ofbiz/branches/release16.11/framework/webapp/src/main/java/
>>>> org/apache/ofbiz/webapp/control/LoginWorker.java (original)
>>>> +++ ofbiz/branches/release16.11/framework/webapp/src/main/java/
>>>> org/apache/ofbiz/webapp/control/LoginWorker.java Mon Feb 19 19:43:15
>>>> 2018
>>>> @@ -24,6 +24,7 @@ import java.math.BigInteger;
>>>> import java.security.cert.X509Certificate;
>>>> import java.sql.Timestamp;
>>>> import java.util.ArrayList;
>>>> +import java.util.Arrays;
>>>> import java.util.Collection;
>>>> import java.util.LinkedList;
>>>> import java.util.List;
>>>>
>>>>
>>>>
>>>
>>>
>>
>
>