[jira] Issue Comment Edited: (FELIX-2138) The resolver should prefer required resources over optional resources to minimize the set of required resources

["Richard S. Hall (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838410#action_12838410 ] 

Richard S. Hall edited comment on FELIX-2138 at 2/25/10 4:58 PM:
-----------------------------------------------------------------

I am not sure I completely understand the issues being raised here, could you explain them in more detail?

Judging from your title change, I think I agree.

      was (Author: rickhall):
    I am not sure I completely understand the issues being raised here, could you explain them in more detail?
  
> The resolver should prefer required resources over optional resources to minimize the set of required resources
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-2138
>                 URL: https://issues.apache.org/jira/browse/FELIX-2138
>             Project: Felix
>          Issue Type: Bug
>          Components: Bundle Repository (OBR)
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>             Fix For: bundlerepository-1.6.0
>
>
> When looking for resources matching a requirement, there is this test:
>             // We don't need to look at resources we've already looked at.
>             if (!m_failedSet.contains(resources[resIdx])
>                 && !m_resolveSet.contains(resources[resIdx]))
>             {
> Unfortunately, it's wrong because the m_resolveSet may have changed since the call to searchResolvingResources() so we can't ignore already resolved resources here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.