You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apache-bugdb@apache.org by Martin Lichtin <li...@bivio.com> on 2000/05/29 00:18:32 UTC
mod_proxy/6127: mod_proxy does not reset timer when reading from client
>Number: 6127
>Category: mod_proxy
>Synopsis: mod_proxy does not reset timer when reading from client
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: apache
>State: open
>Class: sw-bug
>Submitter-Id: apache
>Arrival-Date: Sun May 28 15:20:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator: lichtin@bivio.com
>Release: 1.3.9
>Organization:
apache
>Environment:
Linux 2.2.14-5.0smp
>Description:
mod_proxy (proxy_http.c) does not reset timer when reading from client.
>How-To-Repeat:
Try an upload (through ProxyPass) which takes longer than the TimeOut setting.
>Fix:
***************
*** 355,362 ****
/* send the request data, if any. */
if (ap_should_client_block(r)) {
! while ((i = ap_get_client_block(r, buffer, sizeof buffer)) > 0)
ap_bwrite(f, buffer, i);
}
ap_bflush(f);
ap_kill_timeout(r);
--- 338,347 ----
/* send the request data, if any. */
if (ap_should_client_block(r)) {
! while ((i = ap_get_client_block(r, buffer, sizeof buffer)) > 0) {
! ap_reset_timeout(r);
ap_bwrite(f, buffer, i);
+ }
}
ap_bflush(f);
ap_kill_timeout(r);
>Release-Note:
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, you need]
[to include <ap...@Apache.Org> in the Cc line and make sure the]
[subject line starts with the report component and number, with ]
[or without any 'Re:' prefixes (such as "general/1098:" or ]
["Re: general/1098:"). If the subject doesn't match this ]
[pattern, your message will be misfiled and ignored. The ]
["apbugs" address is not added to the Cc line of messages from ]
[the database automatically because of the potential for mail ]
[loops. If you do not include this Cc, your reply may be ig- ]
[nored unless you are responding to an explicit request from a ]
[developer. Reply only with text; DO NOT SEND ATTACHMENTS! ]