You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by scholzj <gi...@git.apache.org> on 2017/09/17 21:27:58 UTC
[GitHub] kafka pull request #3883: KAFKA-5918: Fix minor typos and errors in the Kafk...
GitHub user scholzj opened a pull request:
https://github.com/apache/kafka/pull/3883
KAFKA-5918: Fix minor typos and errors in the Kafka Streams turotial
I found several minor issues with the Kafka Streams tutorial:
* Some typos
* "As shown above, it illustrate that the constructed ..." instead of "As shown above, it illustrate_s_ that the constructed ..."
* "same as Pipe.java below" instead of "same as Pipe.java _above_"
* Wrong class name in the `LineSplit` example
* Incorrect imports for the code examples
* Missing `import org.apache.kafka.streams.kstream.KStream;` in `LineSplit` and `WordCount` example
* Unnecessary (and potentially confusing) split by whitespaces in the `WorkCount` class (the split into words happened already in `LineSplit`)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scholzj/kafka stream-tutorial-typos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3883.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3883
----
commit 8facfd30948a4c866131c7554ded54bf4213293a
Author: Jakub Scholz <ww...@scholzj.com>
Date: 2017-09-17T21:11:17Z
Fix some typos in the Kafka Streams tutorial
----
---
[GitHub] kafka pull request #3883: KAFKA-5918: Fix minor typos and errors in the Kafk...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/3883
---