You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yiduwangkai (via GitHub)" <gi...@apache.org> on 2023/03/18 03:32:31 UTC
[GitHub] [rocketmq] yiduwangkai opened a new pull request, #6389: merge accurate delay code from 5.0
yiduwangkai opened a new pull request, #6389:
URL: https://github.com/apache/rocketmq/pull/6389
Make sure set the target branch to develop
What is the purpose of the change
merge accurate delay code from 5.0
Brief changelog
change
BrokerController.java
BrokerPathConfigHelper.kava
SendMessageProcessor.java
Message.java
MessageConst.java
ResponseCode.java
example/pom.xml
TimerConsumer.java
TimerProducer.java
pom.xml
store/pom.xml
CommitLog.java
DefaultMessageStore.java
MappedFile.java
MappedFileQueue.java
MessageStore.java
PutMessageStatus.java
MessageStoreConfig.java
ScheduleMessageService.java
Slot.java
TimerCheckpoint.java
TimerLog.java
TimerMessageStore.java
TimerMetrics.java
TimerRequest.java
TimerWheel.java
StoreTestUtils.java
TimerLogTest.java
TimerMessageStoreTest.java
TimerMetricsTest.java
TimerWheelTest.java
Verifying this change
Has been running in our company's test pre-production environment for more than 4 months
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] onejimmyboy commented on pull request #6389: [ISSUE #6275]merge accurate delay code from 5.0
Posted by "onejimmyboy (via GitHub)" <gi...@apache.org>.
onejimmyboy commented on PR #6389:
URL: https://github.com/apache/rocketmq/pull/6389#issuecomment-1475812783
> RocketMQ 5.0 introduce new features by the new module as proxy and container which means you can use it in the totally same way as RocketMQ 4.9 or any other preceding version.
>
> In other words, RocketMQ 5.0 is just another 4.10 version if you don't need these new modules.
>
> So I don't see any reason to migrate code from RocketMQ 5.0 or the demand to use it in 4.9.x
>
> #6325 also explains it.
4.9.4 Support will be discontinued in 2024, which means that after 2024, only version 5. x will be maintained, and version 4. x will no longer be maintained, including bug fixes. Is that so?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] drpmma commented on pull request #6389: [ISSUE #6275]merge accurate delay code from 5.0
Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma commented on PR #6389:
URL: https://github.com/apache/rocketmq/pull/6389#issuecomment-1477230365
> > RocketMQ 5.0 introduce new features by the new module as proxy and container which means you can use it in the totally same way as RocketMQ 4.9 or any other preceding version.
> > In other words, RocketMQ 5.0 is just another 4.10 version if you don't need these new modules.
> > So I don't see any reason to migrate code from RocketMQ 5.0 or the demand to use it in 4.9.x
> > #6325 also explains it.
>
>  4.9.4 Support will be discontinued in 2024, which means that after 2024, only version 5. x will be maintained, and version 4. x will no longer be maintained, including bug fixes. Is that so?
@RongtongJin PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yiduwangkai commented on pull request #6389: [ISSUE #6275]merge accurate delay code from 5.0
Posted by "yiduwangkai (via GitHub)" <gi...@apache.org>.
yiduwangkai commented on PR #6389:
URL: https://github.com/apache/rocketmq/pull/6389#issuecomment-1477155222
> RocketMQ 5.0 introduce new features by the new module as proxy and container which means you can use it in the totally same way as RocketMQ 4.9 or any other preceding version.
>
> In other words, RocketMQ 5.0 is just another 4.10 version if you don't need these new modules.
>
> So I don't see any reason to migrate code from RocketMQ 5.0 or the demand to use it in 4.9.x
>
> #6325 also explains it.
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] drpmma commented on pull request #6389: [ISSUE #6275]merge accurate delay code from 5.0
Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma commented on PR #6389:
URL: https://github.com/apache/rocketmq/pull/6389#issuecomment-1475701330
RocketMQ 5.0 introduce new features by the new module as proxy and container which means you can use it in the totally same way as RocketMQ 4.9 or any other preceding version.
In other words, RocketMQ 5.0 is just another 4.10 version if you don't need this new feature.
So I don't see any reason to migrate code from RocketMQ 5.0 or the demand to use it in 4.9.x
#6325 also explains it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yiduwangkai commented on pull request #6389: merge accurate delay code from 5.0
Posted by "yiduwangkai (via GitHub)" <gi...@apache.org>.
yiduwangkai commented on PR #6389:
URL: https://github.com/apache/rocketmq/pull/6389#issuecomment-1475491027
> Hi @yiduwangkai, we have no plans to merge accurate delay code from 5.0. 4.9.x branch will not introduce new features, only necessary bug fixes will be merged.
@RongtongJin
But there is a lot of demand to use arbitrary latency in 4.9.x. https://github.com/https://github.com/apache/rocketmq/issues/6275, So why not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yiduwangkai commented on pull request #6389: merge accurate delay code from 5.0
Posted by "yiduwangkai (via GitHub)" <gi...@apache.org>.
yiduwangkai commented on PR #6389:
URL: https://github.com/apache/rocketmq/pull/6389#issuecomment-1475489646
> Hi @yiduwangkai, we have no plans to merge accurate delay code from 5.0. 4.9.x branch will not introduce new features, only necessary bug fixes will be merged.
But there is a lot of demandhttps://github.com/apache/rocketmq/issues/6275, So why not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yiduwangkai commented on pull request #6389: [ISSUE #6275]merge accurate delay code from 5.0
Posted by "yiduwangkai (via GitHub)" <gi...@apache.org>.
yiduwangkai commented on PR #6389:
URL: https://github.com/apache/rocketmq/pull/6389#issuecomment-1477158326
> RocketMQ 5.0 introduce new features by the new module as proxy and container which means you can use it in the totally same way as RocketMQ 4.9 or any other preceding version.
>
> In other words, RocketMQ 5.0 is just another 4.10 version if you don't need these new modules.
>
> So I don't see any reason to migrate code from RocketMQ 5.0 or the demand to use it in 4.9.x
>
> #6325 also explains it.
@drpmma @RongtongJin So turn off the pr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] drpmma closed pull request #6389: [ISSUE #6275]merge accurate delay code from 5.0
Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma closed pull request #6389: [ISSUE #6275]merge accurate delay code from 5.0
URL: https://github.com/apache/rocketmq/pull/6389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #6389: merge accurate delay code from 5.0
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin commented on PR #6389:
URL: https://github.com/apache/rocketmq/pull/6389#issuecomment-1475189821
Hi @yiduwangkai, we have no plans to merge accurate delay code from 5.0.
4.9.x branch will not introduce new features, only necessary bug fixes will be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org