You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/09/12 23:04:22 UTC
[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1430:
HDDS-2117. ContainerStateMachine#writeStateMachineData times out.
xiaoyuyao commented on a change in pull request #1430: HDDS-2117. ContainerStateMachine#writeStateMachineData times out.
URL: https://github.com/apache/hadoop/pull/1430#discussion_r323983697
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
##########
@@ -435,13 +435,18 @@ private ExecutorService getCommandExecutor(
.setStage(DispatcherContext.WriteChunkStage.WRITE_DATA)
.setContainer2BCSIDMap(container2BCSIDMap)
.build();
+ CompletableFuture<Message> raftFuture = new CompletableFuture<>();
// ensure the write chunk happens asynchronously in writeChunkExecutor pool
// thread.
CompletableFuture<ContainerCommandResponseProto> writeChunkFuture =
- CompletableFuture.supplyAsync(() ->
- runCommand(requestProto, context), chunkExecutor);
-
- CompletableFuture<Message> raftFuture = new CompletableFuture<>();
+ CompletableFuture.supplyAsync(() -> {
+ try {
+ return runCommand(requestProto, context);
+ } catch (Exception e) {
+ e.printStackTrace();
Review comment:
Can we remove this or adding the exception as Trace log instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org