You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/08 03:55:02 UTC
[GitHub] [incubator-doris] dataroaring commented on a diff in pull request #10007: [Bugfix](load) fix streamload failure due to false unhealthy replica in concurrent stream load
dataroaring commented on code in PR #10007:
URL: https://github.com/apache/incubator-doris/pull/10007#discussion_r891894033
##########
be/src/agent/task_worker_pool.cpp:
##########
@@ -673,38 +673,50 @@ void TaskWorkerPool::_publish_version_worker_thread_callback() {
while (_is_work) {
TAgentTaskRequest agent_task_req;
TPublishVersionRequest publish_version_req;
- {
- std::unique_lock<std::mutex> worker_thread_lock(_worker_thread_lock);
- while (_is_work && _tasks.empty()) {
- _worker_thread_condition_variable.wait(worker_thread_lock);
- }
- if (!_is_work) {
- return;
- }
+ bool current_finished = false;
+ std::vector<TTabletId> error_tablet_ids;
+ Status res = Status::OK();
+ while (!current_finished) {
+ {
Review Comment:
Could we remove this while?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org