You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/17 21:43:55 UTC
[GitHub] [lucene-solr] jtibshirani opened a new pull request #2392: LUCENE-9705: Create Lucene90DocValuesFormat and Lucene90NormsFormat
jtibshirani opened a new pull request #2392:
URL: https://github.com/apache/lucene-solr/pull/2392
For now these are just copies of Lucene80DocValuesFormat and
Lucene80NormsFormat. The existing formats were moved to backwards-codecs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #2392: LUCENE-9705: Create Lucene90DocValuesFormat and Lucene90NormsFormat
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on a change in pull request #2392:
URL: https://github.com/apache/lucene-solr/pull/2392#discussion_r580481448
##########
File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene80/Lucene80DocValuesFormat.java
##########
@@ -163,6 +163,11 @@ public Lucene80DocValuesFormat(Mode mode) {
this.mode = Objects.requireNonNull(mode);
}
+ /**
+ * Note: although this format is only used on older versions, we need to keep the write logic in
+ * addition to the read logic. It's possible for doc values on older segments to be written to
+ * through in-place doc values updates.
Review comment:
Agreed, in-place can mean too many things...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jtibshirani merged pull request #2392: LUCENE-9705: Create Lucene90DocValuesFormat and Lucene90NormsFormat
Posted by GitBox <gi...@apache.org>.
jtibshirani merged pull request #2392:
URL: https://github.com/apache/lucene-solr/pull/2392
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jpountz commented on a change in pull request #2392: LUCENE-9705: Create Lucene90DocValuesFormat and Lucene90NormsFormat
Posted by GitBox <gi...@apache.org>.
jpountz commented on a change in pull request #2392:
URL: https://github.com/apache/lucene-solr/pull/2392#discussion_r579818440
##########
File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene80/Lucene80DocValuesFormat.java
##########
@@ -163,6 +163,11 @@ public Lucene80DocValuesFormat(Mode mode) {
this.mode = Objects.requireNonNull(mode);
}
+ /**
+ * Note: although this format is only used on older versions, we need to keep the write logic in
+ * addition to the read logic. It's possible for doc values on older segments to be written to
+ * through in-place doc values updates.
Review comment:
`in-place` might be a bit misleading since doc-value updates are not in-place but create a new generation of a segment?
```suggestion
* through doc values updates.
```
##########
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesFormat.java
##########
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.codecs.lucene90;
+
+import java.io.IOException;
+import java.util.Objects;
+import org.apache.lucene.codecs.DocValuesConsumer;
+import org.apache.lucene.codecs.DocValuesFormat;
+import org.apache.lucene.codecs.DocValuesProducer;
+import org.apache.lucene.index.DocValuesType;
+import org.apache.lucene.index.IndexWriterConfig;
+import org.apache.lucene.index.SegmentReadState;
+import org.apache.lucene.index.SegmentWriteState;
+import org.apache.lucene.store.DataOutput;
+import org.apache.lucene.util.SmallFloat;
+import org.apache.lucene.util.packed.DirectWriter;
+
+/**
+ * Lucene 8.0 DocValues format.
Review comment:
```suggestion
* Lucene 9.0 DocValues format.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org