[GitHub] [buildstream] gtristan commented on a diff in pull request #1837: Bring back good 'ol python 3.6

["gtristan (via GitHub)" <gi...@apache.org>]

gtristan commented on code in PR #1837:
URL: https://github.com/apache/buildstream/pull/1837#discussion_r1170775903


##########
tox.ini:
##########
@@ -84,21 +84,17 @@ passenv =
 # These keys are not inherited by any other sections
 #
 setenv =
-    py{37,38,39,310,311}: COVERAGE_FILE = {envtmpdir}/.coverage
-    py{37,38,39,310,311}: BST_TEST_HOME = {envtmpdir}
-    py{37,38,39,310,311}: BST_TEST_XDG_CACHE_HOME = {envtmpdir}/cache
-    py{37,38,39,310,311}: BST_TEST_XDG_CONFIG_HOME = {envtmpdir}/config
-    py{37,38,39,310,311}: BST_TEST_XDG_DATA_HOME = {envtmpdir}/share
-
-    # This is required to run tests with python 3.7
-    py37: SETUPTOOLS_ENABLE_FEATURES = "legacy-editable"
-
+    py{36,37,38,39,310}: COVERAGE_FILE = {envtmpdir}/.coverage
+    py{36,37,38,39,310}: BST_TEST_HOME = {envtmpdir}
+    py{36,37,38,39,310}: BST_TEST_XDG_CACHE_HOME = {envtmpdir}/cache
+    py{36,37,38,39,310}: BST_TEST_XDG_CONFIG_HOME = {envtmpdir}/config
+    py{36,37,38,39,310}: BST_TEST_XDG_DATA_HOME = {envtmpdir}/share
     # This is required to get coverage for Cython
-    py{37,38,39,310,311}-!nocover: BST_CYTHON_TRACE = 1
+    py{36,37,38,39,310}-!nocover: BST_CYTHON_TRACE = 1

Review Comment:
   Aha, yes I was confused by other diffs which appeared in the patch but not in `git diff master`, apparently I missed committing some of the changes after resolving conflicts in revert.
   
   Fixed this one along with some other inconsistencies.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org