You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "CzyerChen (via GitHub)" <gi...@apache.org> on 2024/09/14 15:35:18 UTC
[PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
CzyerChen opened a new pull request, #12622:
URL: https://github.com/apache/skywalking/pull/12622
### https://github.com/apache/skywalking/issues/12595
- [x] Update the documentation to include this new feature.
- [x] If it's UI related, attach the screenshots below.
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes https://github.com/apache/skywalking/issues/12595.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#discussion_r1760617498
##########
test/e2e-v2/cases/meter/docker-compose.yml:
##########
@@ -18,7 +18,7 @@ version: '2.1'
services:
oap:
environment:
- SW_METER_ANALYZER_ACTIVE_FILES: spring-micrometer,batch-meter
+ SW_METER_ANALYZER_ACTIVE_FILES: spring-micrometer,batch-meter,java-agent
Review Comment:
Let's activate `java-agent` by default in the application.yml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2352141279
@CzyerChen @weixiang1862 This feature should be a good blog material. We could introduce what we add and why these are important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2352514440
Why some new metrics would affect that?
I just want to be certain, we are bot breaking anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2352139653
There are some irrelevant test cases failing. Please recheck.
Besides https://github.com/apache/skywalking/pull/12622#discussion_r1760615517, I think this is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2352587741
So11y service is using the same service name and instance names, right?
I think we just build extra layer for each service?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#discussion_r1759755253
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/Layer.java:
##########
@@ -234,7 +234,13 @@ public enum Layer {
* Cilium is open source software for providing and transparently securing network connectivity and load balancing
* between application workloads such as application containers or processes.
*/
- CILIUM_SERVICE(38, true);
+ CILIUM_SERVICE(38, true),
+
+ /**
+ * The self observability of SkyWalking Java Agent,
+ * which provides the abilities to measure the tracing performance and error statistics of plugins.
+ */
+ SO11Y_JAVA_AGENT(39, true);
Review Comment:
How your preview works without UI change? Is that possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "CzyerChen (via GitHub)" <gi...@apache.org>.
CzyerChen commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2351511445
> Please update the UI submodule. And I am going to merge [apache/skywalking-java#716](https://github.com/apache/skywalking-java/pull/716), could you add the e2e accordingly?
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #12622:
URL: https://github.com/apache/skywalking/pull/12622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2351522504
Suggestion, as we have Java agent in e2e, we could bump up java agent version, and add more checks to save resource costs of new e2e.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "CzyerChen (via GitHub)" <gi...@apache.org>.
CzyerChen commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2351487568
> I asked for a precision change for the agent side about duration cost by interceptor. The current ms seems not precious enough, which would end all in 0.
>
> My proposal is using nanosecond in agent and storage, but convert to ms or s as this is agent level metric.
execution time storaged in `ns` and shown in `ms`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2352601192
> So11y service is using the same service name and instance names, right?
>
> I think we just build extra layer for each service?
Metrics won't be effected, just service list values and order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#discussion_r1759754724
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/Layer.java:
##########
@@ -234,7 +234,13 @@ public enum Layer {
* Cilium is open source software for providing and transparently securing network connectivity and load balancing
* between application workloads such as application containers or processes.
*/
- CILIUM_SERVICE(38, true);
+ CILIUM_SERVICE(38, true),
+
+ /**
+ * The self observability of SkyWalking Java Agent,
+ * which provides the abilities to measure the tracing performance and error statistics of plugins.
+ */
+ SO11Y_JAVA_AGENT(39, true);
Review Comment:
I think we need a UI PR for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2352553658
> Why some new metrics would affect that?
>
> I just want to be certain, we are bot breaking anything.
Java agent so11y meters generated agent so11y service traffic which make the order of service list changes and generated new agent so11y traffic.
Original test cases has many service traffic actual and expected checks, it is big change to fix all service expected data, so disable `SW_METER_ACTIVE` by default and actived it in meter test case to validate so11y changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2351490525
These are costs of all plugin executions in this minute, right? Could we add some tips to explain this metric and others?
Or do we have a well explained document?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2351243470
I asked for a precision change for the agent side about duration cost by interceptor.
The current ms seems not precious enough, which would end all in 0.
My proposal is using nanosecond in agent and storage, but convert to ms or s as this is agent level metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#discussion_r1760617498
##########
test/e2e-v2/cases/meter/docker-compose.yml:
##########
@@ -18,7 +18,7 @@ version: '2.1'
services:
oap:
environment:
- SW_METER_ANALYZER_ACTIVE_FILES: spring-micrometer,batch-meter
+ SW_METER_ANALYZER_ACTIVE_FILES: spring-micrometer,batch-meter,java-agent
Review Comment:
Let's activate `java-agent` by default in the application.yml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2351507463
Please update the UI submodule. And I am going to merge https://github.com/apache/skywalking-java/pull/716, could you add the e2e accordingly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "CzyerChen (via GitHub)" <gi...@apache.org>.
CzyerChen commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2352328948
> Could you share why Kafka needs to be disabled?
Kafka test cases introduce the producer and consumer in Kafka Basic\Kafka Profiling, and now the agent adds self observability metrics by default, which will affect the original use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "CzyerChen (via GitHub)" <gi...@apache.org>.
CzyerChen commented on code in PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#discussion_r1759755086
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/Layer.java:
##########
@@ -234,7 +234,13 @@ public enum Layer {
* Cilium is open source software for providing and transparently securing network connectivity and load balancing
* between application workloads such as application containers or processes.
*/
- CILIUM_SERVICE(38, true);
+ CILIUM_SERVICE(38, true),
+
+ /**
+ * The self observability of SkyWalking Java Agent,
+ * which provides the abilities to measure the tracing performance and error statistics of plugins.
+ */
+ SO11Y_JAVA_AGENT(39, true);
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2351509719
> Please update the UI submodule. And I am going to merge [apache/skywalking-java#716](https://github.com/apache/skywalking-java/pull/716), could you add the e2e accordingly?
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2352598479
> So11y service is using the same service name and instance names, right?
>
> I think we just build extra layer for each service?
Yes, the SO11Y_JAVA_AGENT service name and instance name is the same as GENERAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#discussion_r1760615517
##########
oap-server/server-starter/src/main/resources/ui-initialized-templates/so11y_java_agent/so11y-instance.json:
##########
@@ -86,7 +89,8 @@
"i": "2",
"type": "Widget",
"widget": {
- "title": "Ignored Context Creation and Completion (Per Minute)"
+ "title": "Ignored Context Creation and Completion (Per Minute)",
+ "tips": "The number of created ignored contexts and finished ignored contexts per minute."
Review Comment:
I think this is not always `per minute`. When you pick several hours/days duration, the unit would be hour or day. You could just remove `per minute` for these tips.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SkyWalking Java Agent self observability dashboard [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #12622:
URL: https://github.com/apache/skywalking/pull/12622#issuecomment-2352300206
Could you share why Kafka needs to be disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org