You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/06/22 06:03:36 UTC

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9591: Syslog

xiaoxiang781216 opened a new pull request, #9591:
URL: https://github.com/apache/nuttx/pull/9591

   ## Summary
   
   - syslog: Remove syslog_force and related stuff 
   - syslog: Add sc_write_force callback 
   
   ## Impact
   
   improve the syslog speed in the interrupt context
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9591: syslog: Add sc_write_force callback

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #9591:
URL: https://github.com/apache/nuttx/pull/9591#discussion_r1239049382


##########
drivers/syslog/syslog_flush.c:
##########
@@ -64,6 +64,7 @@
 
 int syslog_flush(void)
 {
+  FAR struct syslog_channel_s *channel;

Review Comment:
   ```suggestion
   ```



##########
drivers/syslog/syslog_flush.c:
##########
@@ -76,16 +77,17 @@ int syslog_flush(void)
 
   for (i = 0; i < CONFIG_SYSLOG_MAX_CHANNELS; i++)
     {
-      if (g_syslog_channel[i] == NULL)
+      channel = g_syslog_channel[i];

Review Comment:
   ```suggestion
         FAR struct syslog_channel_s *channel = g_syslog_channel[i];
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9591: syslog: Add sc_write_force callback

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9591:
URL: https://github.com/apache/nuttx/pull/9591#discussion_r1239302952


##########
drivers/syslog/syslog_flush.c:
##########
@@ -76,16 +77,17 @@ int syslog_flush(void)
 
   for (i = 0; i < CONFIG_SYSLOG_MAX_CHANNELS; i++)
     {
-      if (g_syslog_channel[i] == NULL)
+      channel = g_syslog_channel[i];

Review Comment:
   Done.



##########
drivers/syslog/syslog_flush.c:
##########
@@ -64,6 +64,7 @@
 
 int syslog_flush(void)
 {
+  FAR struct syslog_channel_s *channel;

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] acassis merged pull request #9591: syslog: Add sc_write_force callback

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #9591:
URL: https://github.com/apache/nuttx/pull/9591


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] TaiJuWu commented on a diff in pull request #9591: syslog: Add sc_write_force callback

Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #9591:
URL: https://github.com/apache/nuttx/pull/9591#discussion_r1239792267


##########
drivers/syslog/syslog_channel.c:
##########
@@ -91,6 +91,7 @@ static const struct syslog_channel_ops_s g_rpmsg_channel_ops =
   syslog_rpmsg_putc,
   syslog_rpmsg_putc,
   syslog_rpmsg_flush,
+  syslog_rpmsg_write,

Review Comment:
   It is same with below line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] TaiJuWu commented on a diff in pull request #9591: syslog: Add sc_write_force callback

Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #9591:
URL: https://github.com/apache/nuttx/pull/9591#discussion_r1239792267


##########
drivers/syslog/syslog_channel.c:
##########
@@ -91,6 +91,7 @@ static const struct syslog_channel_ops_s g_rpmsg_channel_ops =
   syslog_rpmsg_putc,
   syslog_rpmsg_putc,
   syslog_rpmsg_flush,
+  syslog_rpmsg_write,

Review Comment:
   It is the same with below line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org