You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by sy...@apache.org on 2005/10/31 14:19:22 UTC
svn commit: r329817 -
/cocoon/branches/BRANCH_2_1_X/src/blocks/javaflow/java/org/apache/cocoon/forms/flow/java/FormInstance.java
Author: sylvain
Date: Mon Oct 31 05:19:17 2005
New Revision: 329817
URL: http://svn.apache.org/viewcvs?rev=329817&view=rev
Log:
Checking isValid() is bogus since it prevents exiting show() without validation
Modified:
cocoon/branches/BRANCH_2_1_X/src/blocks/javaflow/java/org/apache/cocoon/forms/flow/java/FormInstance.java
Modified: cocoon/branches/BRANCH_2_1_X/src/blocks/javaflow/java/org/apache/cocoon/forms/flow/java/FormInstance.java
URL: http://svn.apache.org/viewcvs/cocoon/branches/BRANCH_2_1_X/src/blocks/javaflow/java/org/apache/cocoon/forms/flow/java/FormInstance.java?rev=329817&r1=329816&r2=329817&view=diff
==============================================================================
--- cocoon/branches/BRANCH_2_1_X/src/blocks/javaflow/java/org/apache/cocoon/forms/flow/java/FormInstance.java (original)
+++ cocoon/branches/BRANCH_2_1_X/src/blocks/javaflow/java/org/apache/cocoon/forms/flow/java/FormInstance.java Mon Oct 31 05:19:17 2005
@@ -45,8 +45,6 @@
private Form form;
private Binding binding;
private Locale locale;
- private boolean isValid;
- private Object validator; // Used?
/**
* Create a form, given the URI of its definition file
@@ -175,7 +173,6 @@
//var result = null;
boolean finished = false;
- this.isValid = false;
do {
sendPageAndWait(uri, bizData);
@@ -187,20 +184,6 @@
FlowHelper.setContextObject(this.getObjectModel(), bizData);
finished = this.form.process(formContext);
-
- // Additional flow-level validation
- if (finished) {
- if (this.validator == null) {
- this.isValid = this.form.isValid();
- } else {
- this.isValid = this.form.isValid() /*& this.validator(this.form, bizData)*/;
- }
- finished = this.isValid;
- }
-
- // FIXME: Theoretically, we should clone the form widget (this.form) to ensure it keeps its
- // value with the continuation. We don't do it since there should me not much pratical consequences
- // except a sudden change of repeaters whose size changed from a continuation to another.
} while(!finished);
}