You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/06/04 07:59:55 UTC
Review Request 59793: SENTRY-1780: FullUpdateInitializer does not
kill the threads whenever getFullHMSSnapshot throws an...
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59793/
-----------------------------------------------------------
Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
Bugs: SENTRY-1780
https://issues.apache.org/jira/browse/SENTRY-1780
Repository: sentry
Description
-------
SENTRY-1780: FullUpdateInitializer does not kill the threads whenever getFullHMSSnapshot throws an exception
Diffs
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java efd3fa3d24b4160812f02ccc89c39ec17f7b367e
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d410a6ce3bd535823ca656ab1fc879fd38336922
Diff: https://reviews.apache.org/r/59793/diff/1/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 59793: SENTRY-1780: FullUpdateInitializer does not
kill the threads whenever getFullHMSSnapshot throws an...
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59793/#review176974
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On June 4, 2017, 6:48 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59793/
> -----------------------------------------------------------
>
> (Updated June 4, 2017, 6:48 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1780
> https://issues.apache.org/jira/browse/SENTRY-1780
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1780: FullUpdateInitializer does not kill the threads whenever getFullHMSSnapshot throws an exception
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java efd3fa3d24b4160812f02ccc89c39ec17f7b367e
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d410a6ce3bd535823ca656ab1fc879fd38336922
>
>
> Diff: https://reviews.apache.org/r/59793/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 59793: SENTRY-1780: FullUpdateInitializer does not
kill the threads whenever getFullHMSSnapshot throws an...
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59793/#review176952
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On June 4, 2017, 6:48 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59793/
> -----------------------------------------------------------
>
> (Updated June 4, 2017, 6:48 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1780
> https://issues.apache.org/jira/browse/SENTRY-1780
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1780: FullUpdateInitializer does not kill the threads whenever getFullHMSSnapshot throws an exception
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java efd3fa3d24b4160812f02ccc89c39ec17f7b367e
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d410a6ce3bd535823ca656ab1fc879fd38336922
>
>
> Diff: https://reviews.apache.org/r/59793/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 59793: SENTRY-1780: FullUpdateInitializer does not
kill the threads whenever getFullHMSSnapshot throws an...
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On June 5, 2017, 3:11 a.m., Na Li wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
> > Lines 390 (patched)
> > <https://reviews.apache.org/r/59793/diff/2/?file=1741031#file1741031line395>
> >
> > what is the benefit of catching exception here?
> >
> > Its caller catches the exception and logs it. Providing more info on the failure.
The exception was already logged. The only possible reaction is to retry the same thing again - the caller can't do anything useful with it.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59793/#review176892
-----------------------------------------------------------
On June 4, 2017, 6:48 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59793/
> -----------------------------------------------------------
>
> (Updated June 4, 2017, 6:48 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1780
> https://issues.apache.org/jira/browse/SENTRY-1780
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1780: FullUpdateInitializer does not kill the threads whenever getFullHMSSnapshot throws an exception
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java efd3fa3d24b4160812f02ccc89c39ec17f7b367e
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d410a6ce3bd535823ca656ab1fc879fd38336922
>
>
> Diff: https://reviews.apache.org/r/59793/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 59793: SENTRY-1780: FullUpdateInitializer does not
kill the threads whenever getFullHMSSnapshot throws an...
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59793/#review176892
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 390 (patched)
<https://reviews.apache.org/r/59793/#comment250434>
what is the benefit of catching exception here?
Its caller catches the exception and logs it. Providing more info on the failure.
- Na Li
On June 4, 2017, 6:48 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59793/
> -----------------------------------------------------------
>
> (Updated June 4, 2017, 6:48 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1780
> https://issues.apache.org/jira/browse/SENTRY-1780
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1780: FullUpdateInitializer does not kill the threads whenever getFullHMSSnapshot throws an exception
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java efd3fa3d24b4160812f02ccc89c39ec17f7b367e
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d410a6ce3bd535823ca656ab1fc879fd38336922
>
>
> Diff: https://reviews.apache.org/r/59793/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 59793: SENTRY-1780: FullUpdateInitializer does not
kill the threads whenever getFullHMSSnapshot throws an...
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59793/
-----------------------------------------------------------
(Updated June 4, 2017, 6:48 p.m.)
Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
Changes
-------
Small code cleanup
Bugs: SENTRY-1780
https://issues.apache.org/jira/browse/SENTRY-1780
Repository: sentry
Description
-------
SENTRY-1780: FullUpdateInitializer does not kill the threads whenever getFullHMSSnapshot throws an exception
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java efd3fa3d24b4160812f02ccc89c39ec17f7b367e
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d410a6ce3bd535823ca656ab1fc879fd38336922
Diff: https://reviews.apache.org/r/59793/diff/2/
Changes: https://reviews.apache.org/r/59793/diff/1-2/
Testing
-------
Thanks,
Alexander Kolbasov