You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "ARE404 (via GitHub)" <gi...@apache.org> on 2026/10/10 09:47:23 UTC
[PR] feat(workhub): simplify coordination and unify remote task workflows [maka]
ARE404 opened a new pull request, #6051:
URL: https://github.com/apache/maka/pull/6051
## Summary
Refs #5745
- Refactor WorkHub as a coordination Agent: use WorkHub's configuration for delegated execution, preserve target Session ownership, and propagate temporary execution policy through child/Graph work and recovery.
- Add a remote-chat destination setting that routes chats to the single WorkHub Session, including compact numeric/letter question answers and simplified channel labels.
- Add `wn` to show progress and next-step suggestions for the three most recent works, then place the selected prompt draft in the desktop composer without executing it.
- Preserve user intent in handoffs and simplify task identity rails, result-update spacing, and answered-question disclosures. Clicking an option now advances or submits the question; keyboard selection remains available.
- Fix frozen-store proxy access when applying delegated execution policy.
## Verification
- Runtime Host, UI, and desktop renderer/main TypeScript checks passed during implementation.
- Re-ran 67 focused tests for execution authority, action gating, remote routing/choices, task identity, draft extraction, and option-click submission: 67 passed, 0 failed.
- Shared disclosure/answer identity regression run: 44 passed, 0 failed.
- Native Electron: exercised `wn` discovery, selection, and draft insertion using SQL/CS336 tasks; verified that drafting started no target Session invocation. Checked answered-choice expansion and result identity rails in the app.
- `git diff --check` passed. Merge check against current upstream `main` reports no conflicts.
- Full cross-platform packaging and end-to-end remote-provider delivery were not rerun. Generated summaries and faithful handoffs remain model-driven; prompt instructions are not a hard enforcement boundary.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: OpenAI Codex implemented the refactor, remote routing, and UI changes; added tests; and performed native validation. Retain the Generated-by trailer in the squash commit.
## Checklist
- [x] Tests cover the change and fail without it
- [ ] Lint, format, typecheck and the affected suites pass locally
Focused typechecks/tests and whitespace validation passed; the full repository lint/format gate was not rerun for this PR.
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
Generated-by: Codex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] feat(workhub): simplify coordination and unify remote task workflows [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #6051:
URL: https://github.com/apache/maka/pull/6051#discussion_r4237545861
##########
packages/runtime-host/src/protocol/index.ts:
##########
@@ -104,7 +104,8 @@ export const RUNTIME_HOST_REGISTRATION_SCHEMA_VERSION = 1 as const;
export const RUNTIME_HOST_PROTOCOL_VERSION = 0 as const;
// Increment when the same protocol version no longer guarantees safe Client-Host
// interoperability. Mismatches are rejected before domain commands are admitted.
-export const RUNTIME_HOST_COMPATIBILITY_EPOCH = 212 as const;
+export const RUNTIME_HOST_COMPATIBILITY_EPOCH = 214 as const;
Review Comment:
**[P3] Allocate a distinct compatibility epoch before integration**
Epoch 214 now conflicts with open #5548 at dc7a4fdd4b89b4845349b5543c56c2eb81a9b042, which declares 214 for a different wire contract. The move fixes the previous epoch-213 collision but not unique allocation. Main is currently 212 and 215 is currently unused across 188 open heads checked. Coordinate the number and recheck immediately before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] feat(workhub): simplify coordination and unify remote task workflows [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #6051:
URL: https://github.com/apache/maka/pull/6051#discussion_r4237396759
##########
packages/runtime-host/src/protocol/index.ts:
##########
@@ -104,7 +104,8 @@ export const RUNTIME_HOST_REGISTRATION_SCHEMA_VERSION = 1 as const;
export const RUNTIME_HOST_PROTOCOL_VERSION = 0 as const;
// Increment when the same protocol version no longer guarantees safe Client-Host
// interoperability. Mismatches are rejected before domain commands are admitted.
-export const RUNTIME_HOST_COMPATIBILITY_EPOCH = 212 as const;
+export const RUNTIME_HOST_COMPATIBILITY_EPOCH = 213 as const;
Review Comment:
[P3] Reconcile this epoch with the other open protocol changes
The current open heads of #5394 (`2fc0e4c2`) and #5969 (`c19d60ec`) also declare epoch 213, for different contracts. This PR changes WorkHub coordination/configuration semantics. Coordinate a distinct final epoch at integration so incompatible clients and Hosts do not share the same handshake value.
##########
packages/runtime-host/src/server/root-turn-coordinator.ts:
##########
@@ -3177,6 +3266,7 @@ export class RootTurnCoordinator implements HostedExecutionAuthority {
active.continuation = plan.continuation;
});
stream = this.manager.resumeSafeBoundaryContinuation(active.continuation!, {
+ executionPolicy,
Review Comment:
[P2] Refresh the effective question policy before the physical successor
`executionPolicy` was captured when this logical Turn started. If WorkHub later steers an ordinary running task, `returnExecutionQuestions` updates its live policy to `questions: 'return'`, but this loop still passes the old `undefined` policy. RuntimeKernel consequently creates a successor without the missing-information return policy, and `AskUserQuestion` can suspend it again after WorkHub's relay was removed. I exercised the production physical-handoff fixture: the live policy was `return` before sealing, the Turn completed, and the successor context had no question policy. Supplying the updated policy made that same probe pass. Resolve the latest effective policy for the same execution lineage before resuming; do not confuse this physical successor with an ordinary later user Turn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] feat(workhub): simplify coordination and unify remote task workflows [maka]
Posted by "ARE404 (via GitHub)" <gi...@apache.org>.
ARE404 merged PR #6051:
URL: https://github.com/apache/maka/pull/6051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org