You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "iemejia (via GitHub)" <gi...@apache.org> on 2023/10/02 16:22:16 UTC
[PR] AVRO-3878: Rename default git branch to be 'main' [avro]
iemejia opened a new pull request, #2537:
URL: https://github.com/apache/avro/pull/2537
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3878: Rename default git branch to be 'main' [avro]
Posted by "KalleOlaviNiemitalo (via GitHub)" <gi...@apache.org>.
KalleOlaviNiemitalo commented on PR #2537:
URL: https://github.com/apache/avro/pull/2537#issuecomment-1743811463
Other references to the `master` branch of this repository:
* `doc/`:
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/doc/content/en/docs/%2B%2Bversion%2B%2B/IDL%20Language/_index.md?plain=1#L509>
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/doc/content/en/project/How%20to%20contribute/_index.md?plain=1#L67>
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/doc/content/en/project/How%20to%20contribute/_index.md?plain=1#L260>
* `lang/csharp/`:
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/lang/csharp/README.md?plain=1#L1>
* `lang/php/`: I'm not very familiar with PHP but <https://getcomposer.org/doc/articles/versions.md#branches> seems to say that composer.json uses `dev-` as a prefix for branches.
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/lang/php/README.md?plain=1#L1>
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/lang/php/README.md?plain=1#L31>
* `lang/py/`:
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/lang/py/README.md?plain=1#L18>
* `lang/rust/`: many
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/lang/rust/README.tpl#L6>
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/lang/rust/README.tpl#L11>
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/lang/rust/README.tpl#L15>
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/lang/rust/avro/README.md?plain=1#L25>
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/lang/rust/avro/README.md?plain=1#L103>
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/lang/rust/avro/README.md?plain=1#L660>
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/lang/rust/avro/README.md?plain=1#L664>
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/lang/rust/avro/src/lib.rs#L92>
+ <https://github.com/apache/avro/blob/69679cb6113cdf437e8138c85f0a9e080c36b186/lang/rust/avro/src/rabin.rs#L136>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3878: Rename default git branch to be 'main' [avro]
Posted by "iemejia (via GitHub)" <gi...@apache.org>.
iemejia merged PR #2537:
URL: https://github.com/apache/avro/pull/2537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3878: Rename default git branch to be 'main' [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #2537:
URL: https://github.com/apache/avro/pull/2537#discussion_r1345770315
##########
lang/csharp/README.md:
##########
@@ -1,4 +1,4 @@
-# Avro C# [](https://travis-ci.org/apache/avro) [](https://www.nuget.org/packages/Apache.Avro)
+# Avro C# [](https://travis-ci.org/apache/avro) [](https://www.nuget.org/packages/Apache.Avro)
Review Comment:
Better replace the badge to point to Github Actions CI.
```
[](https://github.com/apache/avro/actions/workflows/test-lang-csharp.yml)
```
##########
lang/csharp/README.md:
##########
@@ -1,4 +1,4 @@
-# Avro C# [](https://travis-ci.org/apache/avro) [](https://www.nuget.org/packages/Apache.Avro)
+# Avro C# [](https://travis-ci.org/apache/avro) [](https://www.nuget.org/packages/Apache.Avro)
Review Comment:
Better replace the badge to point to Github Actions CI.
```
[](https://github.com/apache/avro/actions/workflows/test-lang-csharp.yml)
```
[](https://github.com/apache/avro/actions/workflows/test-lang-csharp.yml)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3878: Rename default git branch to be 'main' [avro]
Posted by "KalleOlaviNiemitalo (via GitHub)" <gi...@apache.org>.
KalleOlaviNiemitalo commented on code in PR #2537:
URL: https://github.com/apache/avro/pull/2537#discussion_r1345754707
##########
lang/csharp/README.md:
##########
@@ -1,4 +1,4 @@
-# Avro C# [](https://travis-ci.org/apache/avro) [](https://www.nuget.org/packages/Apache.Avro)
+# Avro C# [](https://travis-ci.org/apache/avro) [](https://www.nuget.org/packages/Apache.Avro)
Review Comment:
<https://app.travis-ci.com/github/apache/avro> shows "This is not an active repository"; the latest attempt to build any branch was 8 months ago from commit 12c1587f83b37226646db133ad7b0e8ef97caac0. The TravisCI config files were already deleted in AVRO-3653 <https://github.com/apache/avro/pull/1948>, so the badge should be deleted too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3878: Rename default git branch to be 'main' [avro]
Posted by "iemejia (via GitHub)" <gi...@apache.org>.
iemejia commented on code in PR #2537:
URL: https://github.com/apache/avro/pull/2537#discussion_r1345872208
##########
lang/csharp/README.md:
##########
@@ -1,4 +1,4 @@
-# Avro C# [](https://travis-ci.org/apache/avro) [](https://www.nuget.org/packages/Apache.Avro)
+# Avro C# [](https://travis-ci.org/apache/avro) [](https://www.nuget.org/packages/Apache.Avro)
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3878: Rename default git branch to be 'main' [avro]
Posted by "KalleOlaviNiemitalo (via GitHub)" <gi...@apache.org>.
KalleOlaviNiemitalo commented on PR #2537:
URL: https://github.com/apache/avro/pull/2537#issuecomment-1743820918
If PHP users have followed the instructions in `lang/php/README.md` and copied `"apache/avro": "dev-master"` into `composer.json` files in their projects, and the branch is renamed, then will all of those projects fail to build? The GitHub web site can redirect to the new name of the branch but I don't know whether redirection works with Composer too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3878: Rename default git branch to be 'main' [avro]
Posted by "iemejia (via GitHub)" <gi...@apache.org>.
iemejia commented on PR #2537:
URL: https://github.com/apache/avro/pull/2537#issuecomment-1744288042
Thanks for pointing out the missing instances. I somehow had a filter on my IDE for `.github` and missed all the others 🤦 !
For the php case I am going to go preventive and rename it to `dev-main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3878: Rename default git branch to be 'main' [avro]
Posted by "iemejia (via GitHub)" <gi...@apache.org>.
iemejia commented on code in PR #2537:
URL: https://github.com/apache/avro/pull/2537#discussion_r1345702573
##########
lang/rust/avro/benches/serde.rs:
##########
@@ -296,7 +296,7 @@ fn bench_big_schema_read_100_000_record(c: &mut Criterion) {
// This benchmark reads from the `benches/quickstop-null.avro` file, which was pulled from
// the `goavro` project benchmarks:
-// https://github.com/linkedin/goavro/blob/master/fixtures/quickstop-null.avro
+// https://github.com/linkedin/goavro/blob/main/fixtures/quickstop-null.avro
Review Comment:
Oups fixed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3878: Rename default git branch to be 'main' [avro]
Posted by "RyanSkraba (via GitHub)" <gi...@apache.org>.
RyanSkraba commented on code in PR #2537:
URL: https://github.com/apache/avro/pull/2537#discussion_r1343671860
##########
lang/rust/avro/benches/serde.rs:
##########
@@ -296,7 +296,7 @@ fn bench_big_schema_read_100_000_record(c: &mut Criterion) {
// This benchmark reads from the `benches/quickstop-null.avro` file, which was pulled from
// the `goavro` project benchmarks:
-// https://github.com/linkedin/goavro/blob/master/fixtures/quickstop-null.avro
+// https://github.com/linkedin/goavro/blob/main/fixtures/quickstop-null.avro
Review Comment:
This doesn't look right!
##########
lang/php/README.md:
##########
@@ -28,7 +28,7 @@ your project's `composer.json` configuration file, and run `composer install`:
```json
{
"require-dev": {
- "apache/avro": "dev-master"
+ "apache/avro": "dev-main"
Review Comment:
Looks like this is right: https://getcomposer.org/doc/articles/aliases.md#why-aliases-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org