You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/28 03:42:19 UTC
[GitHub] [spark] xuanyuanking opened a new pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
xuanyuanking opened a new pull request #28936:
URL: https://github.com/apache/spark/pull/28936
### What changes were proposed in this pull request?
The `optimizedPlan` in IncrementalExecution should also be scoped in `withActive`.
### Why are the changes needed?
Follow-up of SPARK-30798 for the Streaming side.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650743113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650709315
**[Test build #124595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124595/testReport)** for PR 28936 at commit [`5ca38fd`](https://github.com/apache/spark/commit/5ca38fd63233752f302225b1ab3d0f54f5847831).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650686881
**[Test build #124589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124589/testReport)** for PR 28936 at commit [`5ca38fd`](https://github.com/apache/spark/commit/5ca38fd63233752f302225b1ab3d0f54f5847831).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650708883
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650742749
**[Test build #124595 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124595/testReport)** for PR 28936 at commit [`5ca38fd`](https://github.com/apache/spark/commit/5ca38fd63233752f302225b1ab3d0f54f5847831).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on pull request #28936: [SPARK-32126][SS] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-651623749
Sorry for the late.
Agree we need a new Jira for this. I should create it by myself, thanks for your help! @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650708303
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124589/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650709430
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650686260
cc @cloud-fan @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650686881
**[Test build #124589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124589/testReport)** for PR 28936 at commit [`5ca38fd`](https://github.com/apache/spark/commit/5ca38fd63233752f302225b1ab3d0f54f5847831).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650743113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650709315
**[Test build #124595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124595/testReport)** for PR 28936 at commit [`5ca38fd`](https://github.com/apache/spark/commit/5ca38fd63233752f302225b1ab3d0f54f5847831).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650708225
**[Test build #124589 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124589/testReport)** for PR 28936 at commit [`5ca38fd`](https://github.com/apache/spark/commit/5ca38fd63233752f302225b1ab3d0f54f5847831).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650708300
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650687026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650708300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28936: [SPARK-32126][SS] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650899447
Thanks, @xuanyuanking and @cloud-fan . I created SPARK-32126 and update the title.
Merged to master/3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650687026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28936: [SPARK-30798][SS][FOLLOW-UP] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28936:
URL: https://github.com/apache/spark/pull/28936#issuecomment-650709430
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28936: [SPARK-32126][SS] Scope Session.active in IncrementalExecution
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28936:
URL: https://github.com/apache/spark/pull/28936
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org