You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/28 12:24:50 UTC

[GitHub] [incubator-shardingsphere] dongzl opened a new pull request #4098: add antlr visitor for MySQL TCLStatement.

dongzl opened a new pull request #4098: add antlr visitor for MySQL TCLStatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/4098
 
 
   For #3914 .
   
   Changes proposed in this pull request:
   - add antlr visitor for MySQL TCLStatement.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on issue #4098: add antlr visitor for MySQL TCLStatement.

Posted by GitBox <gi...@apache.org>.
dongzl commented on issue #4098: add antlr visitor for MySQL TCLStatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-580052027
 
 
   #4106 .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4098: add antlr visitor for MySQL TCLStatement.

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #4098: add antlr visitor for MySQL TCLStatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/4098#discussion_r372178455
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java
 ##########
 @@ -311,6 +327,31 @@ public ASTNode visitSetAutoCommit(final SetAutoCommitContext ctx) {
         return result;
     }
     
+    @Override
+    public ASTNode visitAutoCommitValue(final AutoCommitValueContext ctx) {
 
 Review comment:
   Hi `AutoCommitSegment` is necessary for `SetAutoCommitStatement`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on issue #4098: add antlr visitor for MySQL TCLStatement.

Posted by GitBox <gi...@apache.org>.
dongzl commented on issue #4098: add antlr visitor for MySQL TCLStatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-579623734
 
 
   close this pr directly, submit a new pr on master branch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4098: add antlr visitor for MySQL TCLStatement.

Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4098: add antlr visitor for MySQL TCLStatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/4098#discussion_r372216412
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java
 ##########
 @@ -311,6 +327,31 @@ public ASTNode visitSetAutoCommit(final SetAutoCommitContext ctx) {
         return result;
     }
     
+    @Override
+    public ASTNode visitAutoCommitValue(final AutoCommitValueContext ctx) {
 
 Review comment:
   done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4098: add antlr visitor for MySQL TCLStatement.

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4098: add antlr visitor for MySQL TCLStatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-579238912
 
 
   ## Pull Request Test Coverage Report for [Build 1515](https://coveralls.io/builds/28375900)
   
   * **0** of **16**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **126** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.1%**) to **66.425%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28375900/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L318) | 0 | 16 | 0.0%
   <!-- | **Total:** | **0** | **16** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28375900/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L124) | 126 | 0% |
   <!-- | **Total:** | **126** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28375900/badge)](https://coveralls.io/builds/28375900) |
   | :-- | --: |
   | Change from base [Build 757](https://coveralls.io/builds/28375068): |  0.1% |
   | Covered Lines: | 10899 |
   | Relevant Lines: | 16408 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl removed a comment on issue #4098: add antlr visitor for MySQL TCLStatement.

Posted by GitBox <gi...@apache.org>.
dongzl removed a comment on issue #4098: add antlr visitor for MySQL TCLStatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-579231529
 
 
   /run ci

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl edited a comment on issue #4098: add antlr visitor for MySQL TCLStatement.

Posted by GitBox <gi...@apache.org>.
dongzl edited a comment on issue #4098: add antlr visitor for MySQL TCLStatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-579623734
 
 
   close this pr directly, submit a new pr on master branch. #4106 .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4098: add antlr visitor for MySQL TCLStatement.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4098: add antlr visitor for MySQL TCLStatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-579238912
 
 
   ## Pull Request Test Coverage Report for [Build 1524](https://coveralls.io/builds/28396382)
   
   * **0** of **5**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.02%**) to **66.296%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28396382/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L317) | 0 | 5 | 0.0%
   <!-- | **Total:** | **0** | **5** | **0.0%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28396382/badge)](https://coveralls.io/builds/28396382) |
   | :-- | --: |
   | Change from base [Build 757](https://coveralls.io/builds/28375068): |  -0.02% |
   | Covered Lines: | 10899 |
   | Relevant Lines: | 16440 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl removed a comment on issue #4098: add antlr visitor for MySQL TCLStatement.

Posted by GitBox <gi...@apache.org>.
dongzl removed a comment on issue #4098: add antlr visitor for MySQL TCLStatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-580052027
 
 
   #4106 .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4098: add antlr visitor for MySQL TCLStatement.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4098: add antlr visitor for MySQL TCLStatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-579238912
 
 
   ## Pull Request Test Coverage Report for [Build 1517](https://coveralls.io/builds/28376905)
   
   * **0** of **6**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.02%**) to **66.292%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28376905/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L318) | 0 | 6 | 0.0%
   <!-- | **Total:** | **0** | **6** | **0.0%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28376905/badge)](https://coveralls.io/builds/28376905) |
   | :-- | --: |
   | Change from base [Build 757](https://coveralls.io/builds/28375068): |  -0.02% |
   | Covered Lines: | 10899 |
   | Relevant Lines: | 16441 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl closed pull request #4098: add antlr visitor for MySQL TCLStatement.

Posted by GitBox <gi...@apache.org>.
dongzl closed pull request #4098: add antlr visitor for MySQL TCLStatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/4098
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on issue #4098: add antlr visitor for MySQL TCLStatement.

Posted by GitBox <gi...@apache.org>.
dongzl commented on issue #4098: add antlr visitor for MySQL TCLStatement.
URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-579231529
 
 
   /run ci

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services