[GitHub] [kafka] ableegoldman commented on a change in pull request #10482: KAFKA-12499: add transaction timeout verification

[GitBox <gi...@apache.org>]

ableegoldman commented on a change in pull request #10482:
URL: https://github.com/apache/kafka/pull/10482#discussion_r607423468



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java
##########
@@ -106,7 +107,7 @@ public StreamsProducer(final StreamsConfig config,
                 producerConfigs.put(ProducerConfig.TRANSACTIONAL_ID_CONFIG, applicationId + "-" + taskId);
 
                 eosBetaProducerConfigs = null;
-
+                verifyTransactionTimeoutCompatibility(producerConfigs, config);

Review comment:
       +1, we should fail-fast at the level of the KafkaStreams. Otherwise in eos-alpha we actually have to wait for all the individual StreamThreads to be created, started, complete a rebalance to get a task assignment, and _then_ start throwing IllegalArgumentException on each thread when it goes to create a task producer. (Can we also log an error in addition to the IllegalArgumentException?) 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org