You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by Terence Yim <ch...@gmail.com> on 2015/05/06 01:07:37 UTC
[DISCUSS] Removing Guava dependency from twill-api module
Hi all,
I try to address TWILL-69 (Remove guava dependency from twill-api and
twill-common modules) and would like to bring up the discussion about
having a backward incompatible change in 0.6.0 release.
Removing guava will impact TwillController and TwillRunnerService,
which both interfaces currently extends from guava Service and are in
twilll-api. Do you guys think it's ok to break backward compatibility
in 0.6.0? Or any suggestions on how to do it without break
compatibility?
Currently I have a backward incompatible change that is posted in PR
https://github.com/apache/incubator-twill/pull/32
Thanks,
Terence
Re: [DISCUSS] Removing Guava dependency from twill-api module
Posted by Keith Turner <ke...@deenlo.com>.
I am currently using Twill and I have no objection to a breaking API
change.
On Tue, May 5, 2015 at 7:07 PM, Terence Yim <ch...@gmail.com> wrote:
> Hi all,
>
> I try to address TWILL-69 (Remove guava dependency from twill-api and
> twill-common modules) and would like to bring up the discussion about
> having a backward incompatible change in 0.6.0 release.
>
> Removing guava will impact TwillController and TwillRunnerService,
> which both interfaces currently extends from guava Service and are in
> twilll-api. Do you guys think it's ok to break backward compatibility
> in 0.6.0? Or any suggestions on how to do it without break
> compatibility?
>
> Currently I have a backward incompatible change that is posted in PR
> https://github.com/apache/incubator-twill/pull/32
>
> Thanks,
> Terence
>
Re: [DISCUSS] Removing Guava dependency from twill-api module
Posted by Henry Saputra <he...@gmail.com>.
Going to miss the convenience of Guava Service definitions, but I
think this is the right thing to do for API module =)
- Henry
On Tue, May 12, 2015 at 10:50 AM, Terence Yim <ch...@gmail.com> wrote:
> Thanks Henry. Since I don't get any objection to the idea, I'll
> continue with the current approach.
>
> Terence
>
> On Wed, May 6, 2015 at 10:50 AM, Henry Saputra <he...@gmail.com> wrote:
>> I think this is right update for the API signatures to not require
>> Guava dependency.
>>
>> Breaking APIs is usually preferable early, especially when we are
>> still in incubator. Kind of like "pardon the interruption" card we
>> could use for Apache projects in incubation :)
>> But in seriousness, this update would be beneficial in the long run.
>>
>> - Henry
>>
>> On Tue, May 5, 2015 at 4:07 PM, Terence Yim <ch...@gmail.com> wrote:
>>> Hi all,
>>>
>>> I try to address TWILL-69 (Remove guava dependency from twill-api and
>>> twill-common modules) and would like to bring up the discussion about
>>> having a backward incompatible change in 0.6.0 release.
>>>
>>> Removing guava will impact TwillController and TwillRunnerService,
>>> which both interfaces currently extends from guava Service and are in
>>> twilll-api. Do you guys think it's ok to break backward compatibility
>>> in 0.6.0? Or any suggestions on how to do it without break
>>> compatibility?
>>>
>>> Currently I have a backward incompatible change that is posted in PR
>>> https://github.com/apache/incubator-twill/pull/32
>>>
>>> Thanks,
>>> Terence
Re: [DISCUSS] Removing Guava dependency from twill-api module
Posted by Terence Yim <ch...@gmail.com>.
Thanks Henry. Since I don't get any objection to the idea, I'll
continue with the current approach.
Terence
On Wed, May 6, 2015 at 10:50 AM, Henry Saputra <he...@gmail.com> wrote:
> I think this is right update for the API signatures to not require
> Guava dependency.
>
> Breaking APIs is usually preferable early, especially when we are
> still in incubator. Kind of like "pardon the interruption" card we
> could use for Apache projects in incubation :)
> But in seriousness, this update would be beneficial in the long run.
>
> - Henry
>
> On Tue, May 5, 2015 at 4:07 PM, Terence Yim <ch...@gmail.com> wrote:
>> Hi all,
>>
>> I try to address TWILL-69 (Remove guava dependency from twill-api and
>> twill-common modules) and would like to bring up the discussion about
>> having a backward incompatible change in 0.6.0 release.
>>
>> Removing guava will impact TwillController and TwillRunnerService,
>> which both interfaces currently extends from guava Service and are in
>> twilll-api. Do you guys think it's ok to break backward compatibility
>> in 0.6.0? Or any suggestions on how to do it without break
>> compatibility?
>>
>> Currently I have a backward incompatible change that is posted in PR
>> https://github.com/apache/incubator-twill/pull/32
>>
>> Thanks,
>> Terence
Re: [DISCUSS] Removing Guava dependency from twill-api module
Posted by Henry Saputra <he...@gmail.com>.
I think this is right update for the API signatures to not require
Guava dependency.
Breaking APIs is usually preferable early, especially when we are
still in incubator. Kind of like "pardon the interruption" card we
could use for Apache projects in incubation :)
But in seriousness, this update would be beneficial in the long run.
- Henry
On Tue, May 5, 2015 at 4:07 PM, Terence Yim <ch...@gmail.com> wrote:
> Hi all,
>
> I try to address TWILL-69 (Remove guava dependency from twill-api and
> twill-common modules) and would like to bring up the discussion about
> having a backward incompatible change in 0.6.0 release.
>
> Removing guava will impact TwillController and TwillRunnerService,
> which both interfaces currently extends from guava Service and are in
> twilll-api. Do you guys think it's ok to break backward compatibility
> in 0.6.0? Or any suggestions on how to do it without break
> compatibility?
>
> Currently I have a backward incompatible change that is posted in PR
> https://github.com/apache/incubator-twill/pull/32
>
> Thanks,
> Terence