You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Hinsteny (GitHub)" <gi...@apache.org> on 2020/03/16 03:09:18 UTC
[GitHub] [dubbo] Hinsteny opened pull request #5873: [Dubbo-5872] use
QOS command to check if app service is ready
## What is the purpose of the change
Add one QOS command to check application is ready or not!
## Brief changelog
M dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
A dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/command/impl/Ready.java
M dubbo-plugin/dubbo-qos/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.qos.command.BaseCommand
M dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/util/CommandHelperTest.java
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
- [] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [x] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/dubbo/pull/5873 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5873: [Dubbo-5872]
use QOS command to check if app service is ready
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5873?src=pr&el=h1) Report
> Merging [#5873](https://codecov.io/gh/apache/dubbo/pull/5873?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/f8b8b3d2ee6d97f9771411a0fdab3f5701c1fc32&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `27.77%`.
[](https://codecov.io/gh/apache/dubbo/pull/5873?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5873 +/- ##
============================================
- Coverage 61.33% 61.19% -0.14%
+ Complexity 500 496 -4
============================================
Files 981 982 +1
Lines 39147 39165 +18
Branches 5645 5648 +3
============================================
- Hits 24011 23968 -43
- Misses 12516 12561 +45
- Partials 2620 2636 +16
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5873?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/dubbo/config/bootstrap/DubboBootstrap.java](https://codecov.io/gh/apache/dubbo/pull/5873/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9ib290c3RyYXAvRHViYm9Cb290c3RyYXAuamF2YQ==) | `52.69% <25.00%> (-1.23%)` | `0.00 <0.00> (ø)` | |
| [.../java/org/apache/dubbo/qos/command/impl/Ready.java](https://codecov.io/gh/apache/dubbo/pull/5873/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvaW1wbC9SZWFkeS5qYXZh) | `50.00% <50.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/dubbo/remoting/utils/PayloadDropper.java](https://codecov.io/gh/apache/dubbo/pull/5873/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy91dGlscy9QYXlsb2FkRHJvcHBlci5qYXZh) | `46.15% <0.00%> (-30.77%)` | `0.00% <0.00%> (ø%)` | |
| [...bo/config/event/listener/LoggingEventListener.java](https://codecov.io/gh/apache/dubbo/pull/5873/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9ldmVudC9saXN0ZW5lci9Mb2dnaW5nRXZlbnRMaXN0ZW5lci5qYXZh) | `37.50% <0.00%> (-25.00%)` | `0.00% <0.00%> (ø%)` | |
| [...va/org/apache/dubbo/remoting/TimeoutException.java](https://codecov.io/gh/apache/dubbo/pull/5873/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9UaW1lb3V0RXhjZXB0aW9uLmphdmE=) | `22.22% <0.00%> (-11.12%)` | `0.00% <0.00%> (ø%)` | |
| [...ava/org/apache/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/dubbo/pull/5873/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9EdWJib1NodXRkb3duSG9vay5qYXZh) | `65.21% <0.00%> (-10.87%)` | `0.00% <0.00%> (ø%)` | |
| [.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java](https://codecov.io/gh/apache/dubbo/pull/5873/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC9Bc3luY1RvU3luY0ludm9rZXIuamF2YQ==) | `72.41% <0.00%> (-10.35%)` | `0.00% <0.00%> (ø%)` | |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/5873/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `59.09% <0.00%> (-9.10%)` | `0.00% <0.00%> (ø%)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/5873/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `52.27% <0.00%> (-7.96%)` | `19.00% <0.00%> (-2.00%)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/dubbo/pull/5873/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `79.31% <0.00%> (-6.90%)` | `0.00% <0.00%> (ø%)` | |
| ... and [9 more](https://codecov.io/gh/apache/dubbo/pull/5873/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5873?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5873?src=pr&el=footer). Last update [f8b8b3d...cd118e7](https://codecov.io/gh/apache/dubbo/pull/5873?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5873 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] lkj41110 commented on pull request #5873:
[Dubbo-5872] use QOS command to check if app service is ready
Posted by "lkj41110 (GitHub)" <gi...@apache.org>.
Why is the default value not `false`?
[ Full content available at: https://github.com/apache/dubbo/pull/5873 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] chickenlj commented on issue #5873: [Dubbo-5872] use
QOS command to check if app service is ready
Posted by "chickenlj (GitHub)" <gi...@apache.org>.
I think ready should reflect more status than just checking exported services, but still, it's a good start, we can enhance it later.
[ Full content available at: https://github.com/apache/dubbo/pull/5873 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org