You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/26 18:01:43 UTC
[GitHub] [flink-statefun] igalshilman opened a new pull request #194: [FLINK-21154] Move the shared request-reply Protobuf files to a separate artifact
igalshilman opened a new pull request #194:
URL: https://github.com/apache/flink-statefun/pull/194
Currently the `request-reply.proto` file is located in the `statefun-flink-core` artifact. This file is also used to manually generate the Python SDK `request_reply_pb2.py` file. Since we are about to add additional SDKS and expand the number of proto files, we need to standardize the way we share the SDK proto files.
This PR:
1) Adds a maven artifact `statefun-sdk-protos` to hold the request-reply protocol files.
This is both a source artifact and a regular jar. Both artifacts contains the same *proto files.
TBDs/followups:
a) what will we want to publish to maven central?
b) The name of the artifact can be something else.
c) This PR only deals with the request-reply.proto file, but next we should also add the egresses, and the new types.
d) The protobuf package names didn't change yet to reduce to size of the diff, but I think it should happen next.
2) Add a build step to `statefun-flink-core` to build protobufs from that new dependency.
3) Modify the Python SDK build script to include a protobuf generation step.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] tzulitai closed pull request #194: [FLINK-21154] Move the shared request-reply Protobuf files to a separate artifact
Posted by GitBox <gi...@apache.org>.
tzulitai closed pull request #194:
URL: https://github.com/apache/flink-statefun/pull/194
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] tzulitai commented on pull request #194: [FLINK-21154] Move the shared request-reply Protobuf files to a separate artifact
Posted by GitBox <gi...@apache.org>.
tzulitai commented on pull request #194:
URL: https://github.com/apache/flink-statefun/pull/194#issuecomment-768163212
The CI is currently failing for this PR due to some issue with building the Python SDK distribution:
```
/home/runner/work/flink-statefun/flink-statefun/statefun-python-sdk/build-distribution.sh: line 49: protoc: command not found
mv: cannot stat ‘dist/’: No such file or directory
```
This should be related to the changes in 4dc3e81. I'm investigating.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org