You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/11/28 18:07:08 UTC
[GitHub] [lucene] rmuir opened a new pull request #484: Speed up ECJ tasks by avoiding --release
rmuir opened a new pull request #484:
URL: https://github.com/apache/lucene/pull/484
LUCENE-10185 caused a large performance regression in ECJ tasks by using the --release flag. See graph: http://people.apache.org/~mikemccand/lucenebench/antcleantest.html
We recovered some, but not all, of the performance with https://github.com/apache/lucene/pull/483, but it is still 50% slower.
Instead of using --release, we can just disable "terminal deprecation", and leave this check to `javac`. That single check makes this tool run 50% slower, so it isn't worth it.
I've confirmed that the change fully recovers the build performance drop that was lost from LUCENE-10185:
```
Trunk:
Aggregate task times (possibly running in parallel!):
160.88 sec. ecjLintTest
149.60 sec. ecjLintMain
Patch:
Aggregate task times (possibly running in parallel!):
112.95 sec. ecjLintMain
105.10 sec. ecjLintTest
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #484: Speed up ECJ tasks by avoiding --release
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #484:
URL: https://github.com/apache/lucene/pull/484#issuecomment-981145420
We should really go back to release when the echo people have fixed this. So we should leave a Todo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #484: Speed up ECJ tasks by avoiding --release
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #484:
URL: https://github.com/apache/lucene/pull/484#issuecomment-981141614
I think ecj folks may be interested in this one - seems crazy that this creates such a difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir merged pull request #484: Speed up ECJ tasks by avoiding --release
Posted by GitBox <gi...@apache.org>.
rmuir merged pull request #484:
URL: https://github.com/apache/lucene/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #484: Speed up ECJ tasks by avoiding --release
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #484:
URL: https://github.com/apache/lucene/pull/484#issuecomment-981133462
note: the change doesn't help any build machines running with java 11, the `--release` flag acts as a no-op in that case and doesn't cause slowdowns. The change only helps ppl running any newer java version (e.g. java 17). But I think this is probably most developers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #484: Speed up ECJ tasks by avoiding --release
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #484:
URL: https://github.com/apache/lucene/pull/484#issuecomment-981147052
> We should really go back to release when the ecj people have fixed this. So we should leave a Todo.
I already added a comment right where we do this about why. It isn't a TODO, just a statement of fact. Currently, there's no way to run with --release without adding slowdowns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #484: Speed up ECJ tasks by avoiding --release
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #484:
URL: https://github.com/apache/lucene/pull/484#issuecomment-981142619
well, with the latest release, the cost was reduced substantially: https://github.com/apache/lucene/pull/483
so it's trending in the right direction. but still currently 50% slower than if you don't use `--release` (or happen to be running that exact java version)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler edited a comment on pull request #484: Speed up ECJ tasks by avoiding --release
Posted by GitBox <gi...@apache.org>.
uschindler edited a comment on pull request #484:
URL: https://github.com/apache/lucene/pull/484#issuecomment-981145420
We should really go back to release when the ecj people have fixed this. So we should leave a Todo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org