You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/26 13:30:21 UTC
[GitHub] [inlong] ciscozhou opened a new pull request, #6029: [INLONG-6026][Audit] Fix the executed error of ClickHouse audit SQL file
ciscozhou opened a new pull request, #6029:
URL: https://github.com/apache/inlong/pull/6029
### Prepare a Pull Request
- Title: [INLONG-6026][Audit] Fix the executed error of ClickHouse audit SQL file
- Fixes #6026
### Motivation
ClickHouse not support those operations:
```
SET NAMES utf8mb4;
SET FOREIGN_KEY_CHECKS = 0;
SET SQL_MODE = "NO_AUTO_VALUE_ON_ZERO";
SET time_zone = "+00:00";
```
### Verifying this change
- [x] This change is a trivial rework/code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6029: [INLONG-6026][Audit] Fix the executed error of ClickHouse audit SQL file
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6029:
URL: https://github.com/apache/inlong/pull/6029#discussion_r980668249
##########
inlong-audit/audit-store/src/main/java/org/apache/inlong/audit/service/ElasticsearchService.java:
##########
@@ -60,19 +59,29 @@
public class ElasticsearchService implements InsertData, AutoCloseable {
private static final Logger LOG = LoggerFactory.getLogger(ElasticsearchService.class);
+ private static final Gson GSON;
Review Comment:
The issue associated with this PR describes an issue with the ClickHouse SQL files, and it is not recommended to submit other unrelated codes in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] ciscozhou commented on a diff in pull request #6029: [INLONG-6026][Audit] Fix the executed error of ClickHouse audit SQL file
Posted by GitBox <gi...@apache.org>.
ciscozhou commented on code in PR #6029:
URL: https://github.com/apache/inlong/pull/6029#discussion_r981335006
##########
inlong-audit/audit-store/src/main/java/org/apache/inlong/audit/service/ElasticsearchService.java:
##########
@@ -60,19 +59,29 @@
public class ElasticsearchService implements InsertData, AutoCloseable {
private static final Logger LOG = LoggerFactory.getLogger(ElasticsearchService.class);
+ private static final Gson GSON;
Review Comment:
OK, I will remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #6029: [INLONG-6026][Audit] Fix the executed error of ClickHouse audit SQL file
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #6029:
URL: https://github.com/apache/inlong/pull/6029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org