[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #193: [FLINK-27458] Expose allowNonRestoredState flag in JobSpec

[GitBox <gi...@apache.org>]

gyfora commented on code in PR #193:
URL: https://github.com/apache/flink-kubernetes-operator/pull/193#discussion_r864929733


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/spec/JobSpec.java:
##########
@@ -65,4 +65,7 @@ public class JobSpec {
 
     /** Upgrade mode of the Flink job. */
     @EqualsAndHashCode.Exclude private UpgradeMode upgradeMode = UpgradeMode.STATELESS;
+
+    /** Allow checkpoint state that cannot be mapped to any job vertex in tasks. */
+    @EqualsAndHashCode.Exclude private boolean allowNonRestoredState = false;

Review Comment:
   I think we should not exclude this from the equals comparison



##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java:
##########
@@ -223,6 +224,15 @@ protected FlinkConfigBuilder applyJobOrSessionSpec() throws URISyntaxException {
         return this;
     }
 
+    protected FlinkConfigBuilder applyAllowNonRestoredState() {
+        if (spec.getJob() != null) {

Review Comment:
   I think this could easily go into `applyJobOrSessionSpec`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org