You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/09/26 02:17:58 UTC

Re: Review Request 59687: Added tests for recovering ContainerConfig.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/#review186192
-----------------------------------------------------------


Fix it, then Ship it!




This patch LGTM.


src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 1648 (patched)
<https://reviews.apache.org/r/59687/#comment262652>

    extra space?


- Gilbert Song


On May 31, 2017, 11 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59687/
> -----------------------------------------------------------
> 
> (Updated May 31, 2017, 11 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-6894
>     https://issues.apache.org/jira/browse/MESOS-6894
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for recovering ContainerConfig.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp e46643434dc85d766bd549a037f36a89a6738678 
> 
> 
> Diff: https://reviews.apache.org/r/59687/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>