You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "adarshsanjeev (via GitHub)" <gi...@apache.org> on 2023/03/01 05:47:33 UTC

[GitHub] [druid] adarshsanjeev commented on pull request #13793: Add validation for aggregations on __time

adarshsanjeev commented on PR #13793:
URL: https://github.com/apache/druid/pull/13793#issuecomment-1449386515

   After some discussion with Paul about the correct approach, we determined that during compaction time rollup, the LATEST_BY aggregator should fetch the correct value from the object value. Hence, LATEST BY should be okay as a workaround for LATEST, as that still does not function correctly.
   
   Since there are no large issues blocking this PR, I will work on addressing any minor comments and getting this merged since currently it could produce incorrect result without this validation..
   
    I will also try to resolve the issues with LATEST by updating the reference to time column, but this might take a little more effort to come up with the best approach. I will track any updates to this in the github issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org