[GitHub] [incubator-superset] willbarrett commented on a change in pull request #8457: [fix] Improve csv upload functionality

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #8457: [fix] Improve csv upload functionality
URL: https://github.com/apache/incubator-superset/pull/8457#discussion_r342322936
 
 

 ##########
 File path: superset/db_engine_specs/hive.py
 ##########
 @@ -98,7 +98,7 @@ def fetch_data(cls, cursor, limit: int) -> List[Tuple]:
             return []
 
     @classmethod
-    def create_table_from_csv(cls, form, table):  # pylint: disable=too-many-locals
+    def create_table_from_csv(cls, form):  # pylint: disable=too-many-locals
 
 Review comment:
   This change will make the API for the Hive db_engine_spec diverge further from `base`. It would behoove us to keep them in sync.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org