[GitHub] dawidwys commented on a change in pull request #7168: [FLINK-6756][DataStream API] Provide Rich AsyncFunction to Scala API …

[GitBox <gi...@apache.org>]

dawidwys commented on a change in pull request #7168: [FLINK-6756][DataStream API] Provide Rich AsyncFunction to Scala API …
URL: https://github.com/apache/flink/pull/7168#discussion_r238178778
 
 

 ##########
 File path: flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/AsyncDataStreamITCase.scala
 ##########
 @@ -135,3 +158,19 @@ class MyAsyncFunction extends AsyncFunction[Int, Int] {
     resultFuture.complete(Seq(input * 3))
   }
 }
+
+class MyRichAsyncFunction extends RichAsyncFunction[Int, String] {
+  override def asyncInvoke(input: Int, resultFuture: ResultFuture[String]): Unit = {
 
 Review comment:
   Sorry for late response. I wouldn't change the visibility scope for `RichAsyncFunctionIterationRuntimeContext`. I think accessing the `RuntimeContext` is enough in this case (which you do by accessing the `getNumberOfParallelSubtasks`).
   
   Please revert that change, and then I think we will be ready to merge this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services