You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Miretpl (via GitHub)" <gi...@apache.org> on 2026/05/14 21:52:28 UTC
[PR] Helm Chart Documentation Update [airflow]
Miretpl opened a new pull request, #66970:
URL: https://github.com/apache/airflow/pull/66970
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
Update of Helm Chart documentation, which consists of:
1. Parametrisation of min kubernetes and current helm chart versions in the doc
2. Update doc due to the finished separation of `workers` to `workers.celery`/`workers.kubernetes` sections
3. Update the minimum supported Helm version to match our current CI
4. Update all minimum versions of providers to match currently supported minimum Airflow version
5. Filter out deprecated parameters from `Parameters` documentation and add new `Deprecated Parameters` section
6. Automatic generation of `resources`-related doc
7. Updates to `Upgrading to Airflow 3` doc (mostly to not recommend users to use Helm Chart version with a lot of bugs which were fixed in later versions)
8. Misc
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Helm Chart Documentation Update [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on PR #66970:
URL: https://github.com/apache/airflow/pull/66970#issuecomment-4455133548
Also goes for 1.2x line.
Newsfragment - I'm not sure if it should be added here (to main) or in backport PR. I was also wondering if it should be added, but I think that it would be good for users to know (in one way or the other) that we do not know if the chart will render properly on lower versions than min in our CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Helm Chart Documentation Update [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #66970:
URL: https://github.com/apache/airflow/pull/66970#issuecomment-4463822580
### Backport failed to create: chart/v1-2x-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/25942568882'> Run details </a>
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>chart/v1-2x-test</td>
<td><a href="https://github.com/apache/airflow/commit/d9b560cd2df484285b0377cbed73f2ac1267c664"><img src='https://img.shields.io/badge/Commit-d9b560c-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker d9b560c chart/v1-2x-test
```
This should apply the commit to the chart/v1-2x-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README.md#how-to-backport-pr-with-cherry-picker-cli).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Helm Chart Documentation Update [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on code in PR #66970:
URL: https://github.com/apache/airflow/pull/66970#discussion_r3250598667
##########
chart/docs/upgrading-to-airflow-3.rst:
##########
@@ -97,8 +94,7 @@ for details.
Check the minimum Kubernetes version
------------------------------------
-Chart ``1.17.0`` raised the minimum supported Kubernetes version to ``1.30``. Upgrade your cluster before upgrading
-the chart if needed.
+Chart ``1.19.0`` supports ``1.30+`` Kubernetes version. Upgrade your cluster before upgrading the chart if needed.
Review Comment:
I don't think it is needed here as we are referring to the particular helm chart version from the past and respective kubernetes version support for that, so basically it will not be updated in the future e.g. during next helm release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Helm Chart Documentation Update [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #66970:
URL: https://github.com/apache/airflow/pull/66970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Helm Chart Documentation Update [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on code in PR #66970:
URL: https://github.com/apache/airflow/pull/66970#discussion_r3250755950
##########
chart/docs/index.rst:
##########
@@ -62,25 +62,24 @@ deployment on a `Kubernetes <http://kubernetes.io>`__ cluster using the
Requirements
------------
-- Kubernetes 1.30+ cluster
-- Helm 3.10+
-- PV provisioner support in the underlying infrastructure (optionally)
+.. jinja:: global_ctx
+
+ - Kubernetes {{ min_k8s_version }}+ cluster
+ - Helm 3.19+
Review Comment:
Not sure why I skipped it 🤔 - added + I made the k8s and helm version depend on the values set up in CI, so we will not have to worry about upgrading doc in the future when we will update values in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Helm Chart Documentation Update [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #66970:
URL: https://github.com/apache/airflow/pull/66970#issuecomment-4463843457
> I will do the backport manually
Am on it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Helm Chart Documentation Update [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on PR #66970:
URL: https://github.com/apache/airflow/pull/66970#issuecomment-4463833198
I will do the backport manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Helm Chart Documentation Update [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #66970:
URL: https://github.com/apache/airflow/pull/66970#discussion_r3246811426
##########
chart/docs/index.rst:
##########
@@ -190,6 +189,10 @@ This will run database migrations every time there is a ``Sync`` event in Argo C
If you use the ``CeleryExecutor`` with the built-in Redis, it is recommended that you set up a static Redis password either by supplying ``redis.passwordSecretName`` and ``data.brokerUrlSecretName`` or ``redis.password``.
+.. note::
+
+ Due to security concerts, it is not advised to set sensitive values like passwords within the ``values.yaml``.
Review Comment:
Typo
```suggestion
Due to security concerns, it is not advised to set sensitive values like passwords within the ``values.yaml``.
```
##########
chart/docs/upgrading-to-airflow-3.rst:
##########
@@ -97,8 +94,7 @@ for details.
Check the minimum Kubernetes version
------------------------------------
-Chart ``1.17.0`` raised the minimum supported Kubernetes version to ``1.30``. Upgrade your cluster before upgrading
-the chart if needed.
+Chart ``1.19.0`` supports ``1.30+`` Kubernetes version. Upgrade your cluster before upgrading the chart if needed.
Review Comment:
Adding Jinja constants here as well?
##########
chart/docs/index.rst:
##########
@@ -62,25 +62,24 @@ deployment on a `Kubernetes <http://kubernetes.io>`__ cluster using the
Requirements
------------
-- Kubernetes 1.30+ cluster
-- Helm 3.10+
-- PV provisioner support in the underlying infrastructure (optionally)
+.. jinja:: global_ctx
+
+ - Kubernetes {{ min_k8s_version }}+ cluster
+ - Helm 3.19+
Review Comment:
Should we make Helm version also a Jinja value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org