You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/05/04 20:08:22 UTC
Review Request 46994: GEODE-1243: Locator can start on ephemeral port
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46994/
-----------------------------------------------------------
Review request for geode, Jinmei Liao and Kirk Lund.
Repository: geode
Description
-------
GEODE-1243: Locator can start on ephemeral port
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/Locator.java 80a0248d81bffd7ebcc3ae83414ce167f744cd29
geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java 24b859c1a57c44051620670032ac4797f6df413d
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java 7effa3d48926e7bd676511f8e3923cb757fce9f1
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServer.java c8c6f50e962aca409cd54b4269ab56823632dad5
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 5b2c872fa02cd1790ef1122d3bdd332219f9a902
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLocatorLauncherJUnitTestCase.java 62c4d86470be12971e180d50776e004aae76b318
geode-core/src/test/java/com/gemstone/gemfire/distributed/HostedLocatorsDUnitTest.java a5b07ee4c1df25dca3294f08e5fb90832a42a596
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java 3c80d9a2eb8a27796eb5b0b988849a66252744ee
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalFileJUnitTest.java 7dc54523b8d79cddcd1cf011197a09386217ba0e
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalJUnitTest.java bfed4d0f5d1b592e5c867348bdc7c2abad392544
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteFileJUnitTest.java d3edcae9fa1355925307c36b3dcebe0f76e47abc
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java 63c7c74e619817cd331538aa4a82afefc5da4941
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java 2024bf211f63ac1331a8e07189910995e6e8eb77
geode-core/src/test/java/com/gemstone/gemfire/management/LocatorManagementDUnitTest.java 7399ef89584040ca8fb1f522e25e4181dbb7bb85
Diff: https://reviews.apache.org/r/46994/diff/
Testing
-------
Precheckin running...
Thanks,
Jens Deppe
Re: Review Request 46994: GEODE-1243: Locator can start on ephemeral
port
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46994/#review132373
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On May 4, 2016, 8:08 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46994/
> -----------------------------------------------------------
>
> (Updated May 4, 2016, 8:08 p.m.)
>
>
> Review request for geode, Jinmei Liao and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1243: Locator can start on ephemeral port
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/Locator.java 80a0248d81bffd7ebcc3ae83414ce167f744cd29
> geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java 24b859c1a57c44051620670032ac4797f6df413d
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java 7effa3d48926e7bd676511f8e3923cb757fce9f1
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServer.java c8c6f50e962aca409cd54b4269ab56823632dad5
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 5b2c872fa02cd1790ef1122d3bdd332219f9a902
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLocatorLauncherJUnitTestCase.java 62c4d86470be12971e180d50776e004aae76b318
> geode-core/src/test/java/com/gemstone/gemfire/distributed/HostedLocatorsDUnitTest.java a5b07ee4c1df25dca3294f08e5fb90832a42a596
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java 3c80d9a2eb8a27796eb5b0b988849a66252744ee
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalFileJUnitTest.java 7dc54523b8d79cddcd1cf011197a09386217ba0e
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalJUnitTest.java bfed4d0f5d1b592e5c867348bdc7c2abad392544
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteFileJUnitTest.java d3edcae9fa1355925307c36b3dcebe0f76e47abc
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java 63c7c74e619817cd331538aa4a82afefc5da4941
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java 2024bf211f63ac1331a8e07189910995e6e8eb77
> geode-core/src/test/java/com/gemstone/gemfire/management/LocatorManagementDUnitTest.java 7399ef89584040ca8fb1f522e25e4181dbb7bb85
>
> Diff: https://reviews.apache.org/r/46994/diff/
>
>
> Testing
> -------
>
> Precheckin running...
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 46994: GEODE-1243: Locator can start on ephemeral
port
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46994/
-----------------------------------------------------------
(Updated May 13, 2016, 3:58 p.m.)
Review request for geode, Jinmei Liao and Kirk Lund.
Changes
-------
Updated to use new CategoryWithParameterizedRunnerFactory
Repository: geode
Description
-------
GEODE-1243: Locator can start on ephemeral port
Diffs (updated)
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/Locator.java 80a0248d81bffd7ebcc3ae83414ce167f744cd29
geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java 24b859c1a57c44051620670032ac4797f6df413d
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java 7effa3d48926e7bd676511f8e3923cb757fce9f1
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServer.java c8c6f50e962aca409cd54b4269ab56823632dad5
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 5b2c872fa02cd1790ef1122d3bdd332219f9a902
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLocatorLauncherIntegrationTestCase.java 5434a01aec6e1176d14eaec968082ea5c5341831
geode-core/src/test/java/com/gemstone/gemfire/distributed/HostedLocatorsDUnitTest.java 042e8961ca3b30d13665485d9a71e0f00eb03af3
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java 7ee4694762aa4adf1b4fdd5cb15ac929a9fc2994
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalFileIntegrationTest.java c695b07915552b4219c446003306a1d0a3e442b8
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalIntegrationTest.java 897d0fa87f6f4df94cca4e443650e9d6738576e7
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteFileIntegrationTest.java 63f7312da6ce060dd8cc803671a84c250b4baeda
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteIntegrationTest.java a5b883135d5affbf85deb03171d1d6b467925b7d
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteWithCustomLoggingIntegrationTest.java 2e84905fdad800996c696746b4347747e5d0683c
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java 8832459f094dbeecad80c75ee350f39a4aecdcea
geode-core/src/test/java/com/gemstone/gemfire/management/LocatorManagementDUnitTest.java 7399ef89584040ca8fb1f522e25e4181dbb7bb85
Diff: https://reviews.apache.org/r/46994/diff/
Testing
-------
Precheckin running...
Thanks,
Jens Deppe
Re: Review Request 46994: GEODE-1243: Locator can start on ephemeral
port
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46994/#review132317
-----------------------------------------------------------
Fix it, then Ship it!
Change tests to use JUnitParamsRunner instead of Parameterized (GEODE-1350) and then ship it! I'm also experimenting with JUnit 4.13 today and will report what I learn.
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLocatorLauncherJUnitTestCase.java (line 35)
<https://reviews.apache.org/r/46994/#comment196498>
You'll want to convert from this to JUnitParamsRunner because of GEODE-1350
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java (line 58)
<https://reviews.apache.org/r/46994/#comment196499>
Replace with JUnitParamsRunner (GEODE-1350)
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalJUnitTest.java (line 55)
<https://reviews.apache.org/r/46994/#comment196500>
Replace with JUnitParamsRunner (GEODE-1350)
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteFileJUnitTest.java (line 49)
<https://reviews.apache.org/r/46994/#comment196501>
Replace with JUnitParamsRunner (GEODE-1350)
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java (line 62)
<https://reviews.apache.org/r/46994/#comment196502>
Replace with JUnitParamsRunner (GEODE-1350)
- Kirk Lund
On May 4, 2016, 8:08 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46994/
> -----------------------------------------------------------
>
> (Updated May 4, 2016, 8:08 p.m.)
>
>
> Review request for geode, Jinmei Liao and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1243: Locator can start on ephemeral port
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/Locator.java 80a0248d81bffd7ebcc3ae83414ce167f744cd29
> geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java 24b859c1a57c44051620670032ac4797f6df413d
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java 7effa3d48926e7bd676511f8e3923cb757fce9f1
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServer.java c8c6f50e962aca409cd54b4269ab56823632dad5
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java 5b2c872fa02cd1790ef1122d3bdd332219f9a902
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLocatorLauncherJUnitTestCase.java 62c4d86470be12971e180d50776e004aae76b318
> geode-core/src/test/java/com/gemstone/gemfire/distributed/HostedLocatorsDUnitTest.java a5b07ee4c1df25dca3294f08e5fb90832a42a596
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java 3c80d9a2eb8a27796eb5b0b988849a66252744ee
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalFileJUnitTest.java 7dc54523b8d79cddcd1cf011197a09386217ba0e
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalJUnitTest.java bfed4d0f5d1b592e5c867348bdc7c2abad392544
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteFileJUnitTest.java d3edcae9fa1355925307c36b3dcebe0f76e47abc
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java 63c7c74e619817cd331538aa4a82afefc5da4941
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java 2024bf211f63ac1331a8e07189910995e6e8eb77
> geode-core/src/test/java/com/gemstone/gemfire/management/LocatorManagementDUnitTest.java 7399ef89584040ca8fb1f522e25e4181dbb7bb85
>
> Diff: https://reviews.apache.org/r/46994/diff/
>
>
> Testing
> -------
>
> Precheckin running...
>
>
> Thanks,
>
> Jens Deppe
>
>