[GitHub] [pinot] walterddr commented on issue #11168: [multistage][agg] count(*) return final result on leaf causes compilation error

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on issue #11168:
URL: https://github.com/apache/pinot/issues/11168#issuecomment-1648998001

   CC @Jackie-Jiang @shenyu0127 @vvivekiyer 
   basically this unfortunate error only occurs if v2 engine compiles count(*) and at the same time order by (SortNode) gets push down to leaf. 
   - null check assumes QueryContext expression cannot have empty operand;
   - count(*) pushing down to leaf will not have an operand (or the `*` is stripped)
   
   potential solution 
   1. add a dummy (*) during physical plan construction
   2. make v1 QueryContextConverterUtils handle empty operand 
   
   I am more in favor of solution 1. thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org