You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/10/10 17:42:48 UTC

[GitHub] [systemds] mboehm7 commented on pull request #1071: Lasso and PPCA

mboehm7 commented on pull request #1071:
URL: https://github.com/apache/systemds/pull/1071#issuecomment-706586118


   LGTM - thanks for the patch @SvenCelin. This completes the AMLS project.
   
   During the merge, I however, made a number of modifications: (1) added test assertions on expected results, (2) fixed the formatting of tests (tabs over spaces for java code), (3) fixed the integration of ppca (the failure was due to a typo: pcaa instead of ppca), (4) modified the outputs of ppca to match the outputs of pca, (5) modified the parameters of ppca (e.g., passing of k), (6) added documentation for the parameters of lasso, and (7) fixed the formatting of builtin functions (2 space indentation).
     


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org