You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Laszlo Pinter via Review Board <no...@reviews.apache.org> on 2020/02/17 09:42:27 UTC
Review Request 72145: HIVE-21543: Use FilterHooks for show compactions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72145/
-----------------------------------------------------------
Review request for hive, Karen Coppage and Peter Vary.
Repository: hive-git
Description
-------
HIVE-21543: Use FilterHooks for show compactions
Diffs
-----
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java c7e1044589fd1dd970b86259b713d3a44716e7b8
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java d9da00dd2148b0408548ab7d5c88df014a7f7826
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 7b7c2d77914ad56d3ae568aa050725b12969895a
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java 23faa7444a8e9f9c010290539f89b9d8b44f3aa8
Diff: https://reviews.apache.org/r/72145/diff/1/
Testing
-------
Thanks,
Laszlo Pinter
Re: Review Request 72145: HIVE-21543: Use FilterHooks for show
compactions
Posted by Karen Coppage via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72145/#review219606
-----------------------------------------------------------
Ship it!
Ship It!
- Karen Coppage
On Feb. 17, 2020, 3:30 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72145/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2020, 3:30 p.m.)
>
>
> Review request for hive, Karen Coppage and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-21543: Use FilterHooks for show compactions
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java c7e1044589fd1dd970b86259b713d3a44716e7b8
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java d9da00dd2148b0408548ab7d5c88df014a7f7826
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java b6de1460a565f06217f163ca5f733594a0c8406a
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java 23faa7444a8e9f9c010290539f89b9d8b44f3aa8
>
>
> Diff: https://reviews.apache.org/r/72145/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 72145: HIVE-21543: Use FilterHooks for show
compactions
Posted by Laszlo Pinter via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72145/
-----------------------------------------------------------
(Updated Feb. 17, 2020, 3:30 p.m.)
Review request for hive, Karen Coppage and Peter Vary.
Changes
-------
Fix code review findings.
Repository: hive-git
Description
-------
HIVE-21543: Use FilterHooks for show compactions
Diffs (updated)
-----
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java c7e1044589fd1dd970b86259b713d3a44716e7b8
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java d9da00dd2148b0408548ab7d5c88df014a7f7826
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java b6de1460a565f06217f163ca5f733594a0c8406a
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java 23faa7444a8e9f9c010290539f89b9d8b44f3aa8
Diff: https://reviews.apache.org/r/72145/diff/2/
Changes: https://reviews.apache.org/r/72145/diff/1-2/
Testing
-------
Thanks,
Laszlo Pinter
Re: Review Request 72145: HIVE-21543: Use FilterHooks for show
compactions
Posted by Karen Coppage via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72145/#review219605
-----------------------------------------------------------
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java
Lines 403-405 (patched)
<https://reviews.apache.org/r/72145/#comment307791>
nit: My friendly IDE tells me this can be replaced with a Map.computeIfAbsent call. Also true for lines 410, 413.
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java
Lines 440-442 (patched)
<https://reviews.apache.org/r/72145/#comment307790>
I think these are unnecessary
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java
Lines 404 (patched)
<https://reviews.apache.org/r/72145/#comment307792>
Parameter isn't used
- Karen Coppage
On Feb. 17, 2020, 9:42 a.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72145/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2020, 9:42 a.m.)
>
>
> Review request for hive, Karen Coppage and Peter Vary.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-21543: Use FilterHooks for show compactions
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java c7e1044589fd1dd970b86259b713d3a44716e7b8
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java d9da00dd2148b0408548ab7d5c88df014a7f7826
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 7b7c2d77914ad56d3ae568aa050725b12969895a
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java 23faa7444a8e9f9c010290539f89b9d8b44f3aa8
>
>
> Diff: https://reviews.apache.org/r/72145/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Pinter
>
>