[GitHub] [curator] pboutes commented on a change in pull request #380: [CURATOR-590] Add option to disable parent creation for PersistentNode

[GitBox <gi...@apache.org>]

pboutes commented on a change in pull request #380:
URL: https://github.com/apache/curator/pull/380#discussion_r588943612



##########
File path: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
##########
@@ -73,8 +73,10 @@
     private final AtomicReference<byte[]> data = new AtomicReference<byte[]>();
     private final AtomicReference<State> state = new AtomicReference<State>(State.LATENT);
     private final AtomicBoolean authFailure = new AtomicBoolean(false);
+    private volatile boolean parentCreationFailure;

Review comment:
       This is what I thought, but making it an `AtomicBoolean` seems overkill since we're not doing any compare and set operations. Maybe we could just make the `authFailure` field volatile?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org