You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mikhail Khludnev (JIRA)" <ji...@apache.org> on 2015/12/09 22:51:11 UTC

[jira] [Commented] (SOLR-5743) Faceting with BlockJoin support

    [ https://issues.apache.org/jira/browse/SOLR-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049432#comment-15049432 ] 

Mikhail Khludnev commented on SOLR-5743:
----------------------------------------

Colleagues! I need your advice. 
This patch disables query result caching (that requires to make {{NO_CHECK_QCACHE}} public), enforce execution query every time (of course only if params are present).
It calculates facets ongoing with search via DelegatingCollector. It's quite different to what Solr usually does. And it requires to relax encapsulation to access {{ToParentBlockJoinQuery.BlockJoinScorer.swapChildDocs(int[])}}. To accommodate this keeping encapsulation, we can add some public _accessor_ class to {{o.a.l.search.join}} or made it *default* and add a class with {{o.a.l.search.join}} package into solr codebase (%100 ugly). 
As an alternative, we can migrate closer to regular a Solr approach, calculate childDocset and run faceting over it. Please put your opinion, otherwise I'll go to IRC and repeat the question.   

> Faceting with BlockJoin support
> -------------------------------
>
>                 Key: SOLR-5743
>                 URL: https://issues.apache.org/jira/browse/SOLR-5743
>             Project: Solr
>          Issue Type: New Feature
>          Components: faceting
>            Reporter: abipc
>            Assignee: Mikhail Khludnev
>              Labels: features
>             Fix For: 5.5
>
>         Attachments: SOLR-5743.patch, SOLR-5743.patch, SOLR-5743.patch, SOLR-5743.patch, SOLR-5743.patch, SOLR-5743.patch, SOLR-5743.patch, SOLR-5743.patch
>
>
> For a sample inventory(note - nested documents) like this -   
>  <doc>
> <field name="id">10</field>
> <field name="type_s">parent</field>
> <field name="BRAND_s">Nike</field>
> <doc>
> <field name="id">11</field>
> <field name="COLOR_s">Red</field>
> <field name="SIZE_s">XL</field>
> </doc>
> <doc>
> <field name="id">12</field>
> <field name="COLOR_s">Blue</field>
> <field name="SIZE_s">XL</field>
> </doc>
> </doc>
> Faceting results must contain - 
> Red(1)
> XL(1) 
> Blue(1) 
> for a "q=*" query. 
> PS : The inventory example has been taken from this blog - http://blog.griddynamics.com/2013/09/solr-block-join-support.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org