You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/05/22 14:21:05 UTC

[GitHub] [geode] alb3rtobr opened a new pull request #5149: GEODE-8108: Remove System.out.println calls from geode-redis

alb3rtobr opened a new pull request #5149:
URL: https://github.com/apache/geode/pull/5149


   Ticket description, reported by @dschneider-pivotal :
   > 
   > I noticed in SMoveExecutor a number of System.out.println calls. This should not be done. 
   > Either remove the calls (that is what I recommend for SMoveExecutor) or use a logger. 
   > I don't know if SMoveExecutor is the only place this happens so a code scan should be done.
   
   `SMoveExecutor` class was already fixed but I searched for other calls to `System.out.println` in `geode-redis` and I have removed them.
   I also updated the logger of `GeodeRedisServer` class.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #5149: GEODE-8108: Remove System.out.println calls from geode-redis

Posted by GitBox <gi...@apache.org>.

dschneider-pivotal commented on pull request #5149:
URL: https://github.com/apache/geode/pull/5149#issuecomment-632960137


   Thanks for this work. Can you resolve the conflicts in GeodeRedisServer?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] onichols-pivotal merged pull request #5149: GEODE-8108: Remove System.out.println calls from geode-redis

Posted by GitBox <gi...@apache.org>.

onichols-pivotal merged pull request #5149:
URL: https://github.com/apache/geode/pull/5149


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org