You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Denis Garus <ga...@gmail.com> on 2019/11/07 09:10:30 UTC
Review for IGNITE-12300
Hello, Igniters!
I've raised the PR [1] for the issue [2].
Could somebody review it?
1. https://github.com/apache/ignite/pull/7017
2. https://issues.apache.org/jira/browse/IGNITE-12300
Re: Review for IGNITE-12300
Posted by Denis Garus <ga...@gmail.com>.
Hi, Ilya!
I've fixed the flaky test.
Could you have a look?
Thank you!
чт, 7 нояб. 2019 г. в 17:12, Ilya Kasnacheev <il...@gmail.com>:
> Hello!
>
> When I run this test, each case takes 10-40 seconds of hardcore disk usage
> for some reason.
>
> Oops, sorry. I have just commented your ticket.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> чт, 7 нояб. 2019 г. в 16:18, Denis Garus <ga...@gmail.com>:
>
> > >> but keep data in-memory?
> >
> > I don't use any data in tests for this issue; only compute task.
> >
> >
> > >> I have commented JIRA with example of test failure.
> >
> > Unfortunately, I don't see your comment in JIRA [1].
> >
> >
> > 1. https://issues.apache.org/jira/browse/IGNITE-12300
> >
> > чт, 7 нояб. 2019 г. в 15:45, Ilya Kasnacheev <ilya.kasnacheev@gmail.com
> >:
> >
> > > Hello!
> > >
> > > I can see that, but for some reason I can see a lot of disk I/O while
> > > running this test. Is it possible to only use persistence for auth
> > > purposes, but keep data in-memory?
> > >
> > > I have commented JIRA with example of test failure.
> > >
> > > Regards,
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > чт, 7 нояб. 2019 г. в 15:36, Denis Garus <ga...@gmail.com>:
> > >
> > > > Hi, Ilya!
> > > >
> > > > Thank you for the review!
> > > >
> > > > > For some reason, when I run it locally, it starts to use
> persistence,
> > > do
> > > > > you have ideas why that would happen?
> > > >
> > > > The reason is "Authentication can be enabled only for cluster with
> > > enabled
> > > > persistence." [1]
> > > >
> > > > > It also seems to me that
> > > > >
> > > >
> > > >
> > >
> >
> org.apache.ignite.internal.processors.security.compute.closure.ComputeTaskCancelRemoteSecurityContextCheckTest#testClientTaskInitatorCancelOnSrvNode
> > > > > is flaky.
> > > >
> > > > I have started this test 25 times, and it is green. Could you please
> > > > clarify why do you think the test is flaky?
> > > >
> > > >
> > > > 1.
> > > >
> > > >
> > >
> >
> https://github.com/apache/ignite/blob/720706d794e4935779cc2531462595032a547852/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/IgniteAuthenticationProcessor.java#L158
> > > >
> > > > чт, 7 нояб. 2019 г. в 15:02, Ilya Kasnacheev <
> > ilya.kasnacheev@gmail.com
> > > >:
> > > >
> > > > > Hello!
> > > > >
> > > > > I will re-run tests against fresh master, and then commit if they
> > pass.
> > > > >
> > > > > For some reason, when I run it locally, it starts to use
> persistence,
> > > do
> > > > > you have ideas why that would happen?
> > > > >
> > > > > It also seems to me that
> > > > >
> > > > >
> > > >
> > >
> >
> org.apache.ignite.internal.processors.security.compute.closure.ComputeTaskCancelRemoteSecurityContextCheckTest#testClientTaskInitatorCancelOnSrvNode
> > > > > is flaky.
> > > > >
> > > > > Regards,
> > > > > --
> > > > > Ilya Kasnacheev
> > > > >
> > > > >
> > > > > чт, 7 нояб. 2019 г. в 12:10, Denis Garus <ga...@gmail.com>:
> > > > >
> > > > > > Hello, Igniters!
> > > > > >
> > > > > > I've raised the PR [1] for the issue [2].
> > > > > > Could somebody review it?
> > > > > >
> > > > > > 1. https://github.com/apache/ignite/pull/7017
> > > > > > 2. https://issues.apache.org/jira/browse/IGNITE-12300
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Review for IGNITE-12300
Posted by Ilya Kasnacheev <il...@gmail.com>.
Hello!
When I run this test, each case takes 10-40 seconds of hardcore disk usage
for some reason.
Oops, sorry. I have just commented your ticket.
Regards,
--
Ilya Kasnacheev
чт, 7 нояб. 2019 г. в 16:18, Denis Garus <ga...@gmail.com>:
> >> but keep data in-memory?
>
> I don't use any data in tests for this issue; only compute task.
>
>
> >> I have commented JIRA with example of test failure.
>
> Unfortunately, I don't see your comment in JIRA [1].
>
>
> 1. https://issues.apache.org/jira/browse/IGNITE-12300
>
> чт, 7 нояб. 2019 г. в 15:45, Ilya Kasnacheev <il...@gmail.com>:
>
> > Hello!
> >
> > I can see that, but for some reason I can see a lot of disk I/O while
> > running this test. Is it possible to only use persistence for auth
> > purposes, but keep data in-memory?
> >
> > I have commented JIRA with example of test failure.
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > чт, 7 нояб. 2019 г. в 15:36, Denis Garus <ga...@gmail.com>:
> >
> > > Hi, Ilya!
> > >
> > > Thank you for the review!
> > >
> > > > For some reason, when I run it locally, it starts to use persistence,
> > do
> > > > you have ideas why that would happen?
> > >
> > > The reason is "Authentication can be enabled only for cluster with
> > enabled
> > > persistence." [1]
> > >
> > > > It also seems to me that
> > > >
> > >
> > >
> >
> org.apache.ignite.internal.processors.security.compute.closure.ComputeTaskCancelRemoteSecurityContextCheckTest#testClientTaskInitatorCancelOnSrvNode
> > > > is flaky.
> > >
> > > I have started this test 25 times, and it is green. Could you please
> > > clarify why do you think the test is flaky?
> > >
> > >
> > > 1.
> > >
> > >
> >
> https://github.com/apache/ignite/blob/720706d794e4935779cc2531462595032a547852/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/IgniteAuthenticationProcessor.java#L158
> > >
> > > чт, 7 нояб. 2019 г. в 15:02, Ilya Kasnacheev <
> ilya.kasnacheev@gmail.com
> > >:
> > >
> > > > Hello!
> > > >
> > > > I will re-run tests against fresh master, and then commit if they
> pass.
> > > >
> > > > For some reason, when I run it locally, it starts to use persistence,
> > do
> > > > you have ideas why that would happen?
> > > >
> > > > It also seems to me that
> > > >
> > > >
> > >
> >
> org.apache.ignite.internal.processors.security.compute.closure.ComputeTaskCancelRemoteSecurityContextCheckTest#testClientTaskInitatorCancelOnSrvNode
> > > > is flaky.
> > > >
> > > > Regards,
> > > > --
> > > > Ilya Kasnacheev
> > > >
> > > >
> > > > чт, 7 нояб. 2019 г. в 12:10, Denis Garus <ga...@gmail.com>:
> > > >
> > > > > Hello, Igniters!
> > > > >
> > > > > I've raised the PR [1] for the issue [2].
> > > > > Could somebody review it?
> > > > >
> > > > > 1. https://github.com/apache/ignite/pull/7017
> > > > > 2. https://issues.apache.org/jira/browse/IGNITE-12300
> > > > >
> > > >
> > >
> >
>
Re: Review for IGNITE-12300
Posted by Denis Garus <ga...@gmail.com>.
>> but keep data in-memory?
I don't use any data in tests for this issue; only compute task.
>> I have commented JIRA with example of test failure.
Unfortunately, I don't see your comment in JIRA [1].
1. https://issues.apache.org/jira/browse/IGNITE-12300
чт, 7 нояб. 2019 г. в 15:45, Ilya Kasnacheev <il...@gmail.com>:
> Hello!
>
> I can see that, but for some reason I can see a lot of disk I/O while
> running this test. Is it possible to only use persistence for auth
> purposes, but keep data in-memory?
>
> I have commented JIRA with example of test failure.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> чт, 7 нояб. 2019 г. в 15:36, Denis Garus <ga...@gmail.com>:
>
> > Hi, Ilya!
> >
> > Thank you for the review!
> >
> > > For some reason, when I run it locally, it starts to use persistence,
> do
> > > you have ideas why that would happen?
> >
> > The reason is "Authentication can be enabled only for cluster with
> enabled
> > persistence." [1]
> >
> > > It also seems to me that
> > >
> >
> >
> org.apache.ignite.internal.processors.security.compute.closure.ComputeTaskCancelRemoteSecurityContextCheckTest#testClientTaskInitatorCancelOnSrvNode
> > > is flaky.
> >
> > I have started this test 25 times, and it is green. Could you please
> > clarify why do you think the test is flaky?
> >
> >
> > 1.
> >
> >
> https://github.com/apache/ignite/blob/720706d794e4935779cc2531462595032a547852/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/IgniteAuthenticationProcessor.java#L158
> >
> > чт, 7 нояб. 2019 г. в 15:02, Ilya Kasnacheev <ilya.kasnacheev@gmail.com
> >:
> >
> > > Hello!
> > >
> > > I will re-run tests against fresh master, and then commit if they pass.
> > >
> > > For some reason, when I run it locally, it starts to use persistence,
> do
> > > you have ideas why that would happen?
> > >
> > > It also seems to me that
> > >
> > >
> >
> org.apache.ignite.internal.processors.security.compute.closure.ComputeTaskCancelRemoteSecurityContextCheckTest#testClientTaskInitatorCancelOnSrvNode
> > > is flaky.
> > >
> > > Regards,
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > чт, 7 нояб. 2019 г. в 12:10, Denis Garus <ga...@gmail.com>:
> > >
> > > > Hello, Igniters!
> > > >
> > > > I've raised the PR [1] for the issue [2].
> > > > Could somebody review it?
> > > >
> > > > 1. https://github.com/apache/ignite/pull/7017
> > > > 2. https://issues.apache.org/jira/browse/IGNITE-12300
> > > >
> > >
> >
>
Re: Review for IGNITE-12300
Posted by Ilya Kasnacheev <il...@gmail.com>.
Hello!
I can see that, but for some reason I can see a lot of disk I/O while
running this test. Is it possible to only use persistence for auth
purposes, but keep data in-memory?
I have commented JIRA with example of test failure.
Regards,
--
Ilya Kasnacheev
чт, 7 нояб. 2019 г. в 15:36, Denis Garus <ga...@gmail.com>:
> Hi, Ilya!
>
> Thank you for the review!
>
> > For some reason, when I run it locally, it starts to use persistence, do
> > you have ideas why that would happen?
>
> The reason is "Authentication can be enabled only for cluster with enabled
> persistence." [1]
>
> > It also seems to me that
> >
>
> org.apache.ignite.internal.processors.security.compute.closure.ComputeTaskCancelRemoteSecurityContextCheckTest#testClientTaskInitatorCancelOnSrvNode
> > is flaky.
>
> I have started this test 25 times, and it is green. Could you please
> clarify why do you think the test is flaky?
>
>
> 1.
>
> https://github.com/apache/ignite/blob/720706d794e4935779cc2531462595032a547852/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/IgniteAuthenticationProcessor.java#L158
>
> чт, 7 нояб. 2019 г. в 15:02, Ilya Kasnacheev <il...@gmail.com>:
>
> > Hello!
> >
> > I will re-run tests against fresh master, and then commit if they pass.
> >
> > For some reason, when I run it locally, it starts to use persistence, do
> > you have ideas why that would happen?
> >
> > It also seems to me that
> >
> >
> org.apache.ignite.internal.processors.security.compute.closure.ComputeTaskCancelRemoteSecurityContextCheckTest#testClientTaskInitatorCancelOnSrvNode
> > is flaky.
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > чт, 7 нояб. 2019 г. в 12:10, Denis Garus <ga...@gmail.com>:
> >
> > > Hello, Igniters!
> > >
> > > I've raised the PR [1] for the issue [2].
> > > Could somebody review it?
> > >
> > > 1. https://github.com/apache/ignite/pull/7017
> > > 2. https://issues.apache.org/jira/browse/IGNITE-12300
> > >
> >
>
Re: Review for IGNITE-12300
Posted by Denis Garus <ga...@gmail.com>.
Hi, Ilya!
Thank you for the review!
> For some reason, when I run it locally, it starts to use persistence, do
> you have ideas why that would happen?
The reason is "Authentication can be enabled only for cluster with enabled
persistence." [1]
> It also seems to me that
>
org.apache.ignite.internal.processors.security.compute.closure.ComputeTaskCancelRemoteSecurityContextCheckTest#testClientTaskInitatorCancelOnSrvNode
> is flaky.
I have started this test 25 times, and it is green. Could you please
clarify why do you think the test is flaky?
1.
https://github.com/apache/ignite/blob/720706d794e4935779cc2531462595032a547852/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/IgniteAuthenticationProcessor.java#L158
чт, 7 нояб. 2019 г. в 15:02, Ilya Kasnacheev <il...@gmail.com>:
> Hello!
>
> I will re-run tests against fresh master, and then commit if they pass.
>
> For some reason, when I run it locally, it starts to use persistence, do
> you have ideas why that would happen?
>
> It also seems to me that
>
> org.apache.ignite.internal.processors.security.compute.closure.ComputeTaskCancelRemoteSecurityContextCheckTest#testClientTaskInitatorCancelOnSrvNode
> is flaky.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> чт, 7 нояб. 2019 г. в 12:10, Denis Garus <ga...@gmail.com>:
>
> > Hello, Igniters!
> >
> > I've raised the PR [1] for the issue [2].
> > Could somebody review it?
> >
> > 1. https://github.com/apache/ignite/pull/7017
> > 2. https://issues.apache.org/jira/browse/IGNITE-12300
> >
>
Re: Review for IGNITE-12300
Posted by Ilya Kasnacheev <il...@gmail.com>.
Hello!
I will re-run tests against fresh master, and then commit if they pass.
For some reason, when I run it locally, it starts to use persistence, do
you have ideas why that would happen?
It also seems to me that
org.apache.ignite.internal.processors.security.compute.closure.ComputeTaskCancelRemoteSecurityContextCheckTest#testClientTaskInitatorCancelOnSrvNode
is flaky.
Regards,
--
Ilya Kasnacheev
чт, 7 нояб. 2019 г. в 12:10, Denis Garus <ga...@gmail.com>:
> Hello, Igniters!
>
> I've raised the PR [1] for the issue [2].
> Could somebody review it?
>
> 1. https://github.com/apache/ignite/pull/7017
> 2. https://issues.apache.org/jira/browse/IGNITE-12300
>