You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/20 14:34:14 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5872: Fix enroller build error due to out-of-scope ARG

ocket8888 commented on a change in pull request #5872:
URL: https://github.com/apache/trafficcontrol/pull/5872#discussion_r636164097



##########
File path: infrastructure/cdn-in-a-box/enroller/Dockerfile
##########
@@ -43,7 +43,7 @@ COPY ./traffic_ops/v4-client/ /go/src/github.com/apache/trafficcontrol/traffic_o
 COPY ./infrastructure/cdn-in-a-box/ /go/src/github.com/apache/trafficcontrol/infrastructure/cdn-in-a-box/
 
 WORKDIR /go/src/github.com/apache/trafficcontrol/infrastructure/cdn-in-a-box/enroller
-RUN set -o errexit -o nounset; \
+RUN set -o errexit; \

Review comment:
       I did that on purpose instead of copying the arg down, because I was thinking "well it's only unset because I'm not debugging". That's not how that works.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org