You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sirona.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2015/11/10 23:36:05 UTC
PathTrackingDataStore not in repository
Hi guys,
any reason PathTrackingDataStore is not wired in repository?
I'd like to have it at least for consistency with other stores.
wdyt?
Romain Manni-Bucau
@rmannibucau | Blog | Github | LinkedIn | Tomitriber
Re: PathTrackingDataStore not in repository
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Me too, I guess updates to IoC makes Repository less useful - originally
singleton scope was ensured by the repo. Should we deprecate Repository now
then?
+0 from me - understand it as ok but not enough cycles to help a lot
Le 12 nov. 2015 21:03, "Olivier Lamy" <ol...@apache.org> a écrit :
> I'm always happy to have access to simple component unit as
> PathTrackingDataStore
> only etc..
> Can we keep this modularisation in place as possible?
>
>
>
> On 13 November 2015 at 10:09, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > yep the repo, repo is the main entry point and the one responsible of the
> > init of the stores and queries wiring.
> >
> > DataStoreFactory is a bit redundant yes and really just a shortcut for
> the
> > config IMO.
> >
> > In term of semantic when I introduced those I tried to respect that:
> >
> > Repo = you can use it anytime for querying
> > Factory = intended to be used a single time without any guarantee it will
> > return the same instance later on
> >
> > Does it make sense then?
> >
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > <http://www.tomitribe.com>
> >
> > 2015-11-12 14:42 GMT-08:00 Olivier Lamy <ol...@apache.org>:
> >
> > > Hi,
> > > AFAIK It's in DataStoreFactory.
> > > Do you mean the Repository class? Perso I find that a bit redundant.
> > >
> > > On 11 November 2015 at 09:36, Romain Manni-Bucau <
> rmannibucau@gmail.com>
> > > wrote:
> > >
> > > > Hi guys,
> > > >
> > > > any reason PathTrackingDataStore is not wired in repository?
> > > >
> > > > I'd like to have it at least for consistency with other stores.
> > > >
> > > > wdyt?
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau | Blog | Github | LinkedIn | Tomitriber
> > > >
> > >
> > >
> > >
> > > --
> > > Olivier Lamy
> > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >
> >
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
Re: PathTrackingDataStore not in repository
Posted by Olivier Lamy <ol...@apache.org>.
I'm always happy to have access to simple component unit as
PathTrackingDataStore
only etc..
Can we keep this modularisation in place as possible?
On 13 November 2015 at 10:09, Romain Manni-Bucau <rm...@gmail.com>
wrote:
> yep the repo, repo is the main entry point and the one responsible of the
> init of the stores and queries wiring.
>
> DataStoreFactory is a bit redundant yes and really just a shortcut for the
> config IMO.
>
> In term of semantic when I introduced those I tried to respect that:
>
> Repo = you can use it anytime for querying
> Factory = intended to be used a single time without any guarantee it will
> return the same instance later on
>
> Does it make sense then?
>
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com>
>
> 2015-11-12 14:42 GMT-08:00 Olivier Lamy <ol...@apache.org>:
>
> > Hi,
> > AFAIK It's in DataStoreFactory.
> > Do you mean the Repository class? Perso I find that a bit redundant.
> >
> > On 11 November 2015 at 09:36, Romain Manni-Bucau <rm...@gmail.com>
> > wrote:
> >
> > > Hi guys,
> > >
> > > any reason PathTrackingDataStore is not wired in repository?
> > >
> > > I'd like to have it at least for consistency with other stores.
> > >
> > > wdyt?
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau | Blog | Github | LinkedIn | Tomitriber
> > >
> >
> >
> >
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: PathTrackingDataStore not in repository
Posted by Romain Manni-Bucau <rm...@gmail.com>.
yep the repo, repo is the main entry point and the one responsible of the
init of the stores and queries wiring.
DataStoreFactory is a bit redundant yes and really just a shortcut for the
config IMO.
In term of semantic when I introduced those I tried to respect that:
Repo = you can use it anytime for querying
Factory = intended to be used a single time without any guarantee it will
return the same instance later on
Does it make sense then?
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com>
2015-11-12 14:42 GMT-08:00 Olivier Lamy <ol...@apache.org>:
> Hi,
> AFAIK It's in DataStoreFactory.
> Do you mean the Repository class? Perso I find that a bit redundant.
>
> On 11 November 2015 at 09:36, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > Hi guys,
> >
> > any reason PathTrackingDataStore is not wired in repository?
> >
> > I'd like to have it at least for consistency with other stores.
> >
> > wdyt?
> >
> > Romain Manni-Bucau
> > @rmannibucau | Blog | Github | LinkedIn | Tomitriber
> >
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
Re: PathTrackingDataStore not in repository
Posted by Olivier Lamy <ol...@apache.org>.
Hi,
AFAIK It's in DataStoreFactory.
Do you mean the Repository class? Perso I find that a bit redundant.
On 11 November 2015 at 09:36, Romain Manni-Bucau <rm...@gmail.com>
wrote:
> Hi guys,
>
> any reason PathTrackingDataStore is not wired in repository?
>
> I'd like to have it at least for consistency with other stores.
>
> wdyt?
>
> Romain Manni-Bucau
> @rmannibucau | Blog | Github | LinkedIn | Tomitriber
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy